Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

use sourceSets.main for JacocoReport #818

Merged
merged 1 commit into from
Apr 4, 2019
Merged

use sourceSets.main for JacocoReport #818

merged 1 commit into from
Apr 4, 2019

Conversation

epeee
Copy link
Contributor

@epeee epeee commented Apr 4, 2019

it looks like we do get coverage for the test source set now, let's change it to the main source set.

@epeee epeee requested a review from mstachniuk April 4, 2019 17:55
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #818 into master will decrease coverage by 17.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #818       +/-   ##
============================================
- Coverage     94.25%   76.8%   -17.45%     
- Complexity      475    1225      +750     
============================================
  Files           156     219       +63     
  Lines          2244    4458     +2214     
  Branches         77     334      +257     
============================================
+ Hits           2115    3424     +1309     
- Misses           61     922      +861     
- Partials         68     112       +44
Impacted Files Coverage Δ Complexity Δ
...l/gradle/util/handler/ExceptionHandlingTest.groovy
.../org/shipkit/internal/util/RetryManagerTest.groovy
...internal/gradle/release/CiReleasePluginTest.groovy
...ithub/ProjectContributorFetcherFunctionTest.groovy
.../internal/notes/vcs/GitCommitSerializerTest.groovy
...pkit/internal/gradle/util/PomCustomizerTest.groovy
...internal/notes/format/DetailedFormatterTest.groovy
...gradle/git/tasks/CloneGitRepositoryTaskTest.groovy
...radle/git/CloneGitRepositoryTaskFactoryTest.groovy
...radle/versionupgrade/ReplaceVersionTaskTest.groovy
... and 365 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfd87f2...ee2fd1b. Read the comment docs.

@epeee
Copy link
Contributor Author

epeee commented Apr 4, 2019

see coverage for this branch vs coverage on master

mstachniuk
mstachniuk approved these changes Apr 4, 2019
View reviewed changes
Copy link
Contributor

@mstachniuk mstachniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks for that
I copied that from some place but now I can't find a source for that

@epeee epeee merged commit dc60c41 into master Apr 4, 2019
@epeee epeee deleted the ep2 branch April 4, 2019 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mstachniuk mstachniuk mstachniuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epeee @mstachniuk