-
Notifications
You must be signed in to change notification settings - Fork 44
Comparing changes
Open a pull request
base repository: moby/sys
base: mountinfo/v0.7.1
head repository: moby/sys
compare: mountinfo/v0.7.2
- 19 commits
- 20 files changed
- 3 contributors
Commits on Oct 27, 2023
-
mount: fix Go 1.20 errorlint warning
Since Go 1.20, > [t]he fmt.Errorf function now supports multiple occurrences of the %w > format verb, which will cause it to return an error that wraps all of > those error operands. This change, together with newer errorlint, causes the following warning: > mount_unix.go:74:56: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint) > return fmt.Errorf("%w (possible cause: %s)", err, suberr) > ^ As we still want to support Go 1.17, use explicit string for suberr, and add a TODO to switch to %w once we switch to Go 1.20+. Fixes: 487129d Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fb28f89 - Browse repository at this point
Copy the full SHA fb28f89View commit details -
Bump various components used in CI
1. Test with supported Go releases (1.20.x and 1.21.x). Also leave Go 1.17.x since it costs us little to keep supporting it. 2. Bump golangci-lint to the latest released version (v1.55.1). 3. Bump actions/setup-go to v4. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8b02f54 - Browse repository at this point
Copy the full SHA 8b02f54View commit details -
It is already that way for sequential, and Go 1.17 is the oldest version we use in CI, so let's bring other modules go.mod in sync. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 89efe05 - Browse repository at this point
Copy the full SHA 89efe05View commit details -
*: bump golang.org/x/sys to v0.1.0
This is the oldest tagged version of x/sys. This allows to follow Go module's "minimum version selection", leaving it up to users of this module to pick the version they want. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c8f0d56 - Browse repository at this point
Copy the full SHA c8f0d56View commit details -
mount: rm unneeded errorlint annotation
golangci-lint v1.54.2 comes with errorlint v1.4.4, which contains the fix [1] whitelisting all errno comparisons for errors coming from x/sys/unix. Remove the annotation that is no longer needed. Unfortunately, switch on a bare unix error (in mountinfo) still needs to be annotated (see [2]). [1] polyfloyd/go-errorlint#47 [2] polyfloyd/go-errorlint#54 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d6a5209 - Browse repository at this point
Copy the full SHA d6a5209View commit details -
sequential: format via gofumpt
This fixes the following CI error: > sequential_windows.go:114: File is not `gofumpt`-ed (gofumpt) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4700bc3 - Browse repository at this point
Copy the full SHA 4700bc3View commit details
Commits on Jul 3, 2024
-
Merge pull request #129 from kolyshkin/bump-ci
Bump CI to use supported go version, fix a single Go 1.20 issue in mount pkg; rm uneeded errorlint annotations
Configuration menu - View commit details
-
Copy full SHA for 954b593 - Browse repository at this point
Copy the full SHA 954b593View commit details -
Configuration menu - View commit details
-
Copy full SHA for db208c1 - Browse repository at this point
Copy the full SHA db208c1View commit details -
ci/gha: remove macos-11 (deprecated), update to macos-12
From the GitHub actions documentation [1]; > The macos-11 label has been deprecated and will no longer be available > after 28 June 2024. [1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for ab94275 - Browse repository at this point
Copy the full SHA ab94275View commit details -
ci/gha: bump actions/setup-go to v5
Upgrades Node.js runtime from node16 to node20 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 2ca03f0 - Browse repository at this point
Copy the full SHA 2ca03f0View commit details -
ci/gha: bump actions/checkout to v4
Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 2152420 - Browse repository at this point
Copy the full SHA 2152420View commit details -
Makefile: bump golangci-lint to v1.59.1
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 9c5e9e2 - Browse repository at this point
Copy the full SHA 9c5e9e2View commit details -
mountinfo: rm unneeded errorlint annotation
Commit d6a5209 removed most errorlint annotations, with one remaining. golangci-lint v1.59.1 comes with errorlint v1.5.2, which contains the fix [1] whitelisting all errno comparisons for errors coming from x/sys/unix. Remove the annotation that is no longer needed. [1]: polyfloyd/go-errorlint@c0e6cac Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 05d90a3 - Browse repository at this point
Copy the full SHA 05d90a3View commit details -
ci/gha: add ubuntu-24.04 (current LTS)
Ubuntu 24.04 runners are now available (see [1]) [1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 83479f0 - Browse repository at this point
Copy the full SHA 83479f0View commit details -
ci/gha: add macos-14 (m1, arm64)
Add current macOS version, running on arm64 (see [1]) [1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 2a29ebe - Browse repository at this point
Copy the full SHA 2a29ebeView commit details -
ci/gha: drop Go 1.20, add Go 1.22
Test with the current stable version of Go; keeping Go 1.17 as lower boundary for now since it costs us little to keep supporting it. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 057bd48 - Browse repository at this point
Copy the full SHA 057bd48View commit details -
Merge pull request #137 from thaJeztah/refresh_ci
ci/gha: add Go 1.22, update various actions, add macos-12, ubuntu-24.04
Configuration menu - View commit details
-
Copy full SHA for 35f6c4e - Browse repository at this point
Copy the full SHA 35f6c4eView commit details -
symlink: touch-up documentation
- Fix references to EvalSymlinksInScope, which is non-exported - Add relevant links to original implementation / introduction of the code to allow comparing the fork with the original upstream code. - Move GoDoc from the non-exported evalSymlinksInScope function to the exported FollowSymlinkInScope. - Remove the README.md, instead using doc.go to provide the package description. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Configuration menu - View commit details
-
Copy full SHA for 41a565e - Browse repository at this point
Copy the full SHA 41a565eView commit details
Commits on Jul 16, 2024
-
Merge pull request #138 from thaJeztah/fix_symlink_docs
symlink: touch-up documentation
Configuration menu - View commit details
-
Copy full SHA for cafbe42 - Browse repository at this point
Copy the full SHA cafbe42View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff mountinfo/v0.7.1...mountinfo/v0.7.2