Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: moby/sys
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: mountinfo/v0.7.1
Choose a base ref
...
head repository: moby/sys
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: mountinfo/v0.7.2
Choose a head ref
  • 19 commits
  • 20 files changed
  • 3 contributors

Commits on Oct 27, 2023

  1. mount: fix Go 1.20 errorlint warning

    Since Go 1.20,
    
    > [t]he fmt.Errorf function now supports multiple occurrences of the %w
    > format verb, which will cause it to return an error that wraps all of
    > those error operands.
    
    This change, together with newer errorlint, causes the following
    warning:
    
    > mount_unix.go:74:56: non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
    > 					return fmt.Errorf("%w (possible cause: %s)", err, suberr)
    >					                                                  ^
    
    As we still want to support Go 1.17, use explicit string for suberr,
    and add a TODO to switch to %w once we switch to Go 1.20+.
    
    Fixes: 487129d
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    fb28f89 View commit details
    Browse the repository at this point in the history
  2. Bump various components used in CI

    1. Test with supported Go releases (1.20.x and 1.21.x). Also leave Go
       1.17.x since it costs us little to keep supporting it.
    
    2. Bump golangci-lint to the latest released version (v1.55.1).
    
    3. Bump actions/setup-go to v4.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    8b02f54 View commit details
    Browse the repository at this point in the history
  3. */go.mod: set go to 1.17

    It is already that way for sequential, and Go 1.17 is the oldest version
    we use in CI, so let's bring other modules go.mod in sync.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    89efe05 View commit details
    Browse the repository at this point in the history
  4. *: bump golang.org/x/sys to v0.1.0

    This is the oldest tagged version of x/sys. This allows to follow Go
    module's "minimum version selection", leaving it up to users of this
    module to pick the version they want.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    c8f0d56 View commit details
    Browse the repository at this point in the history
  5. mount: rm unneeded errorlint annotation

    golangci-lint v1.54.2 comes with errorlint v1.4.4, which contains
    the fix [1] whitelisting all errno comparisons for errors coming from
    x/sys/unix. Remove the annotation that is no longer needed.
    
    Unfortunately, switch on a bare unix error (in mountinfo) still needs to
    be annotated (see [2]).
    
    [1] polyfloyd/go-errorlint#47
    [2] polyfloyd/go-errorlint#54
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    d6a5209 View commit details
    Browse the repository at this point in the history
  6. sequential: format via gofumpt

    This fixes the following CI error:
    
    > sequential_windows.go:114: File is not `gofumpt`-ed (gofumpt)
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    4700bc3 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge pull request #129 from kolyshkin/bump-ci

    Bump CI to use supported go version, fix a single Go 1.20 issue in mount pkg; rm uneeded errorlint annotations
    thaJeztah authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    954b593 View commit details
    Browse the repository at this point in the history
  2. user: gofumpt

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    db208c1 View commit details
    Browse the repository at this point in the history
  3. ci/gha: remove macos-11 (deprecated), update to macos-12

    From the GitHub actions documentation [1];
    
    > The macos-11 label has been deprecated and will no longer be available
    > after 28 June 2024.
    
    [1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    ab94275 View commit details
    Browse the repository at this point in the history
  4. ci/gha: bump actions/setup-go to v5

    Upgrades Node.js runtime from node16 to node20
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2ca03f0 View commit details
    Browse the repository at this point in the history
  5. ci/gha: bump actions/checkout to v4

    Only a single commit is fetched by default, for the ref/SHA that triggered
    the workflow. Set fetch-depth: 0 to fetch all history for all branches and
    tags.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2152420 View commit details
    Browse the repository at this point in the history
  6. Makefile: bump golangci-lint to v1.59.1

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9c5e9e2 View commit details
    Browse the repository at this point in the history
  7. mountinfo: rm unneeded errorlint annotation

    Commit d6a5209 removed most errorlint
    annotations, with one remaining.
    
    golangci-lint v1.59.1 comes with errorlint v1.5.2, which contains
    the fix [1] whitelisting all errno comparisons for errors coming from
    x/sys/unix. Remove the annotation that is no longer needed.
    
    [1]: polyfloyd/go-errorlint@c0e6cac
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    05d90a3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    83479f0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2a29ebe View commit details
    Browse the repository at this point in the history
  10. ci/gha: drop Go 1.20, add Go 1.22

    Test with the current stable version of Go; keeping Go 1.17 as lower
    boundary for now since it costs us little to keep supporting it.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    057bd48 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #137 from thaJeztah/refresh_ci

    ci/gha: add Go 1.22, update various actions, add macos-12, ubuntu-24.04
    thaJeztah authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    35f6c4e View commit details
    Browse the repository at this point in the history
  12. symlink: touch-up documentation

    - Fix references to EvalSymlinksInScope, which is non-exported
    - Add relevant links to original implementation / introduction of the
      code to allow comparing the fork with the original upstream code.
    - Move GoDoc from the non-exported evalSymlinksInScope function to
      the exported FollowSymlinkInScope.
    - Remove the README.md, instead using doc.go to provide the package
      description.
    
    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    41a565e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge pull request #138 from thaJeztah/fix_symlink_docs

    symlink: touch-up documentation
    thaJeztah authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    cafbe42 View commit details
    Browse the repository at this point in the history
Loading