Change idle implementation to be graceful #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM after comment for unprotected access to i.expired |
Replace the use of net.Conn's SetDeadline() in the idling implementation with a custom monitor that gracefully resets streams and closes the connection. Abrupt termination of the connection using SetDeadline() results in things such as proxy servers being slow to detect idled connections, meaning clients connected to the proxy aren't immediately notified of the connection closure. Also incorporates some of the code from 8239520 to fix the issue of being unable to Reset() a stream if it has data waiting to be read. Signed-off-by: Andy Goldstein <agoldste@redhat.com>
|
This should fix the same issue described in #34 |
dmcgowan
added a commit
that referenced
this pull request
Feb 2, 2015
Change idle implementation to be graceful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the use of net.Conn's SetDeadline() in the idling implementation
with a custom monitor that gracefully resets streams and closes the
connection. Abrupt termination of the connection using SetDeadline()
results in things such as proxy servers being slow to detect idled
connections, meaning clients connected to the proxy aren't immediately
notified of the connection closure.
Also incorporates some of the code from
8239520 to fix the issue of being
unable to Reset() a stream if it has data waiting to be read.
Signed-off-by: Andy Goldstein agoldste@redhat.com