Proposed fix for #8979 #9064
Merged
Proposed fix for #8979 #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Could you please amend to sign your commit? |
recursive-madman
force-pushed
the
patch-1
branch
from
2e95c0d to
d3e54fd
Compare
|
Sure. I was expecting you to ask me to turn the spaces to tabs (which I also did now). |
|
@recursive-madman does it fix the problem on your machine? because I can only test it doesnt break current functionality/cli output |
|
Perhaps an inline comment should be added to clarify why this change was made, to prevent future coders from "cleaning it up" if they didn't know the change was to accommodate 32 bit machines. |
…sumably fixes moby#8979. Signed-off-by: Recursive Madman <recursive.madman@gmx.de>
recursive-madman
force-pushed
the
patch-1
branch
from
d3e54fd to
4c2cb04
Compare
|
@jfrazelle yes, it does solve the problem. |
recursive-madman
force-pushed
the
patch-1
branch
from
4c2cb04 to
5cd5319
Compare
|
any chance for this to get merged? any more adjustments necessary? |
|
LGTM (ping @jfrazelle @crosbymichael) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't loose precision when parsing image size on 32 bit machines.
Presumably fixes #8979.