Compute TarSum on storage of image layer content #8964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlhawn
force-pushed
the
image_checksum
branch
from
30e193f to
2987aa3
Compare
| @@ -74,19 +76,44 @@ func LoadImage(root string) (*Image, error) { | |||
| return img, nil | |||
| } | |||
|
|
|||
| // StoreImage stores file system layer data for the given image to the | |||
| // image's registered storage driver. Image metadata is stored in a file | |||
| // at the specified root directory. If `computeChecksum` is true, this | |||
There was a problem hiding this comment.
I don't see a computeChecksum flag, is the comment referring to a removed piece of code?
There was a problem hiding this comment.
Ah, yes. I considered adding a flag at first, but decided not to. I'll remove it now.
|
Besides the comment on the comment, LGTM. |
Now, newly created/imported layers will have the checksum of the layer diff computed and stored in the image json file. For now, it is not an error if the computed checksum does not match an existing checksum, only a warning message is logged. The eventual goal is to use the checksums in the image JSON to verify the integrity of the layer contents when doing `docker load` or `docker pull`, and error out if it does not match. Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
jlhawn
force-pushed
the
image_checksum
branch
from
2987aa3 to
059e589
Compare
|
@unclejack gets a ping, @jfrazelle gets a ping, @tiborvass gets a ping, and @crosbymichael gets a ping! |
|
LGTM |
1 similar comment
|
LGTM |
|
Happy here. |
|
LGTM |
crosbymichael
added a commit
that referenced
this pull request
Nov 14, 2014
Compute TarSum on storage of image layer content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, newly created/imported layers will have the checksum of
the layer diff computed and stored in the image json file.
For now, it is not an error if the computed checksum does not
match an existing checksum, only a warning message is logged. The
eventual goal is to use the checksums in the image JSON to verify
the integrity of the layer contents when doing
docker loadordocker pull, and error out if it does not match.Docker-DCO-1.1-Signed-off-by: Josh Hawn josh.hawn@docker.com (github:jlhawn)