Adding custom bridge support to docker run #6704
Conversation
|
Ping @crosbymichael @vieux |
| @@ -888,7 +888,8 @@ removed before the image is removed. | |||
| -m, --memory="" Memory limit (format: <number><optional unit>, where unit = b, k, m or g) | |||
| --name="" Assign a name to the container | |||
| --net="bridge" Set the Network mode for the container | |||
| 'bridge': creates a new network stack for the container on the docker bridge | |||
| 'bridge': creates a new network stack for the container on the default docker bridge | |||
There was a problem hiding this comment.
I don't know in the generated docs, but the output looks weird (tabs/spaces)
|
Ping @vieux @crosbymichael |
|
It looks like your script picked up some vendor changes on the formatting
|
|
Sorry about that.. Fixed. |
|
Do you think we should do anything around creating a bridge if it does not exist? |
|
I want to eventually. We could something like --net "bridge:name:CIDR" which would instruct docker to create the bridge. I am not sure who needs that feature at this point though. WDYT? |
|
We talked about creation at the meeting and decided that it's easier to add |
|
needs an update of |
|
@SvenDowideit Has docs/man/docker-run.1.md been updated recently? I don't see '--net' option mentioned at all. |
|
@crosbymichael @vieux do you guys have any other comments? |
|
Ping @vieux |
|
Sorry @vishh, we will take a look soon, I moved this into the |
|
@vishh Looks like there are some conflicts, can you rebase this? |
|
@vishh yes, I see |
|
@SvenDowideit: I have updated docker-run.1.md. |
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
… docker run. Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
Docker-DCO-1.1-Signed-off-by: Vishnu Kannan <vishnuk@google.com> (github: vishh)
|
Ping @vieux @crosbymichael |
| the other side of the pair will be placed inside the container's namespaces in | ||
| addition to the `loopback` interface. An IP address will be allocated for | ||
| containers on the bridge's network and trafic will be routed though this bridge | ||
| to the container. |
|
LGTM once my/ostezer's comment is a addressed. |
|
There is an ongoing discussion on #docker-dev about handling custom On Fri Jul 18 2014 at 10:43:11 AM, Fred Lifton notifications@github.com
|
|
Is there any resolution to this from #docker-dev discussion? |
|
Ping @erikh. Are you working on a generic solution for netowkr related On Tue, Aug 12, 2014 at 12:30 PM, Tristan Zajonc notifications@github.com
|
|
That’s coming later.
|
|
Just to list our use case here: we would like containers to be assigned to specific subnets in AWS VPC environment. This pull request seems like a nice simple solution, in line with --net option, that shouldn't be too disruptive to future plans. So +1 for this feature unless there's a clear alternative in the works that I'm unaware of. |
|
Hi @vishh, this PR is causing the same concerns as described in #7436 (comment) . Bottom line, we strongly agree with the need for this feature, but want to implement a different way, using hooks/plugins. There are a whole bunch of people interested in helping with this, so we'll probably put together some sort of hackfest to get it done. Sorry for closing this, I hope you'll join the fun :) |
Docker will now accept a pre-existing bridge as an argument to docker run to create the networking stack on the user specified bridge instead of docker0.
Fixes issue #6155.