Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup permissions of cache directories for user namespaces #6600

Closed
wants to merge 1 commit into from

Conversation

dineshs-altiscale
Copy link
Contributor

Docker-DCO-1.1-Signed-off-by: Dinesh Subhraveti dineshs@altiscale.com (github: dineshs-altiscale)

Docker-DCO-1.1-Signed-off-by: Dinesh Subhraveti <dineshs@altiscale.com> (github: dineshs-altiscale)
@vieux
Copy link
Contributor

vieux commented Jun 23, 2014

ping @crosbymichael

1 similar comment
@unclejack
Copy link
Contributor

ping @crosbymichael

@crosbymichael
Copy link
Contributor

@dineshs-altiscale Can you explain why we need to change the permissions for this to work?

@dineshs-altiscale
Copy link
Contributor Author

Several steps along the way before execve assume root. But once the UID mappings are enforced somewhere midway in the driver, it's suddenly not true anymore. For example, sysinit running as docker-root needs to be able to read .dockerenv which is owned by host root.

This is about the minimal change required to get through the initialization phase without stumbling on missing permission. I arrived here after several iterations -- first 0755 for container.root, then to 0711 and then to 0710.

@tiborvass
Copy link
Contributor

@crosbymichael do we still need this? If we do this needs a serious rebase.

@crosbymichael
Copy link
Contributor

Thanks for these PRs. We finally have the Go PRs merged to add support into libcontainer and will be working on user namespaces soon after the Go 1.4 release is out.

We will review the filesystem operations after the execution aspect is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants