daemon: remove Daemon.NetworkControllerEnabled #49052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function was added in eb982e7, at which time networking was not yet implemented for Windows, resulting in a panic when trying to call network-related endpoints. That's no longer the case, so we should be able to add network-endpoints unconditionally. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/api
status/2-code-review
area/networking
area/daemon
kind/refactor
thaJeztah
commented
Dec 8, 2024
Comment on lines
717
to
+718
| distributionrouter.NewRouter(opts.daemon.ImageBackend()), | ||
| network.NewRouter(opts.daemon, opts.cluster), |
There was a problem hiding this comment.
This line will conflict with #49051, so depending on which one gets merged first may require a rebase / conflict fix
vvoland
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added in eb982e7, at which time networking was not yet implemented for Windows, resulting in a panic when trying to call network-related endpoints.
That's no longer the case, so we should be able to add network-endpoints unconditionally.