pkg/containerfs: move to internal #48097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container package is the only consumer of this function in our code and there's no known external users; https://grep.app/search?q=.CleanScopedPath%28&filter[lang][0]=Go Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/storage
status/2-code-review
kind/refactor
- Improve some GoDoc to use docs links - Change the Windows stub to an actual wrapper function, as we don't want it to be updateable, and it currently shows as "variable" on pkg.go.dev, which is confusing. - Remove "import" comments in preparation of moving this package Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The only external consumer are the `graphdriver` and `graphdriver/shim` packages in github.com/docker/go-plugins-helpers, which depended on [ContainerFS][1], which was removed in 9ce2b30. graphdriver-plugins were deprecated in 6da604a, and support for them removed in 555dac5, so removing this should not be an issue. Ideally this package would've been moved inside `daemon/internal`, but it's used by the `daemon` (cleanupContainer), `plugin` package, and by `graphdrivers`, so needs to be in the top-level `internal/` package. [1]: https://github.com/docker/go-plugins-helpers/blob/6eecb7beb65124bb44a23848bb46e98b4f50ae18/graphdriver/api.go#L218 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
internalize_containerfs
branch
from
e89c952 to
f2970e5
Compare
vvoland
approved these changes
Jul 1, 2024
cpuguy83
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/pkg#32989pkg/containerfs: remove CleanScopedPath and make it internal
The container package is the only consumer of this function in our code
and there's no known external users;
https://grep.app/search?q=.CleanScopedPath%28&filter[lang][0]=Go
pkg/containerfs: cleanup GoDoc, and make Windows a proper wrapper
want it to be updateable, and it currently shows as "variable" on
pkg.go.dev, which is confusing.
pkg/containerfs: move to internal
The only external consumer are the
graphdriverandgraphdriver/shimpackages in github.com/docker/go-plugins-helpers, which depended on
ContainerFS, which was removed in 9ce2b30.
graphdriver-plugins were deprecated in 6da604a,
and support for them removed in 555dac5,
so removing this should not be an issue.
Ideally this package would've been moved inside
daemon/internal, but it's usedby the
daemon(cleanupContainer),pluginpackage, and bygraphdrivers,so needs to be in the top-level
internal/package.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)