Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: bump github.com/aws/aws-sdk-go-v2 to v1.24.1 #47373

Merged
merged 3 commits into from
Feb 15, 2024
Merged

vendor: bump github.com/aws/aws-sdk-go-v2 to v1.24.1 #47373

merged 3 commits into from
Feb 15, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Feb 12, 2024

In preparation for buildkit v0.13

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vvoland
vendor: bump github.com/aws/aws-sdk-go-v2 to v1.24.1
999f90a 
In preparation for buildkit v0.13

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland added this to the 26.0.0 milestone Feb 12, 2024
@vvoland vvoland self-assigned this Feb 12, 2024
@vvoland vvoland mentioned this pull request Feb 12, 2024
Merged
@vvoland
Copy link
Contributor Author

vvoland commented Feb 12, 2024 

=== Failed
=== FAIL: daemon/logger/awslogs TestNewAWSLogsClientUserAgentHandler (0.00s)
    cloudwatchlogs_test.go:146: assertion failed: error is not nil: not found, ResolveEndpointV2

=== FAIL: daemon/logger/awslogs TestNewAWSLogsClientLogFormatHeaderHandler/json/emf (0.00s)
    cloudwatchlogs_test.go:189: assertion failed: error is not nil: not found, ResolveEndpointV2

=== FAIL: daemon/logger/awslogs TestNewAWSLogsClientLogFormatHeaderHandler/#00 (0.00s)
    cloudwatchlogs_test.go:189: assertion failed: error is not nil: not found, ResolveEndpointV2

=== FAIL: daemon/logger/awslogs TestNewAWSLogsClientLogFormatHeaderHandler (0.00s)

=== FAIL: daemon/logger/awslogs TestNewAWSLogsClientAWSLogsEndpoint (0.00s)
    cloudwatchlogs_test.go:220: assertion failed: error is not nil: not found, ResolveEndpointV2

=== FAIL: daemon/logger/awslogs TestNewAWSLogsClientCredentialEndpointDetect (0.00s)
    cloudwatchlogs_test.go:1688: assertion failed: error is not nil: not found, ResolveEndpointV2

@stewartsmith @PeterCai7 are you able to help with these failures? 👀

@crazy-max
Copy link
Member

crazy-max commented Feb 14, 2024 •
edited
Loading

Argh didn't recall the aws sdk was used on moby sorry for that. Will keep that in mind next time we bump these dependencies on buildkit.

About tests issue it seems related to aws/aws-sdk-go-v2#2370 (comment) so I guess you need to bump github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to a more recent version.

@vvoland
vendor: bump github.com/aws/aws-sdk-go-v2/service/cloudwatchlogs to v…
70a4a9c 
…1.32.0

v1.33.0 is also available, but it would also cause
`github.com/aws/aws-sdk-go-v2` change from v1.24.1 to v1.25.0

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@crazy-max
Copy link
Member

https://github.com/moby/moby/actions/runs/7904361943/job/21576367616#step:6:20

daemon/logger/awslogs/cloudwatchlogs.go:412:35: SA1019: cloudwatchlogs.WithEndpointResolver is deprecated: EndpointResolver and WithEndpointResolver. Providing a value for this field will likely prevent you from using any endpoint-related service features released after the introduction of EndpointResolverV2 and BaseEndpoint. To migrate an EndpointResolver implementation that uses a custom endpoint, set the client option BaseEndpoint instead. (staticcheck)

Looks similar to moby/buildkit@ba7b949

@vvoland
Copy link
Contributor Author

vvoland commented Feb 14, 2024

Thanks!

@vvoland
awslogs: Replace depreacted WithEndpointResolver usage
2aa13e9 
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland marked this pull request as ready for review February 15, 2024 09:38
@vvoland vvoland requested a review from samuelkarp as a code owner February 15, 2024 09:38
thaJeztah
thaJeztah approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! And massive thank you to @crazy-max !

@thaJeztah thaJeztah merged commit bf053be into moby:master Feb 15, 2024
126 checks passed
@austinvazquez austinvazquez mentioned this pull request Apr 17, 2024
Merged
@thaJeztah thaJeztah mentioned this pull request Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

@samuelkarp samuelkarp Awaiting requested review from samuelkarp samuelkarp is a code owner

Assignees

@vvoland vvoland

Labels
area/logging status/2-code-review
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@vvoland @crazy-max @thaJeztah