Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/homedir: remove deprecated Key() and GetShortcutString() #47130

Merged
merged 1 commit into from
Jan 22, 2024
Merged

pkg/homedir: remove deprecated Key() and GetShortcutString() #47130

merged 1 commit into from
Jan 22, 2024

Conversation

thaJeztah
Copy link
Member

These were deprecated in ddd9665 (v25.0), and 3c1de2e, and are no longer used.

- Description for the changelog

- pkg/homedir: remove deprecated Key() and GetShortcutString()

- A picture of a cute animal (not mandatory but encouraged)

@thaJeztah
pkg/homedir: remove deprecated Key() and GetShortcutString()
2767d9b 
These were deprecated in ddd9665 (v25.0),
and 3c1de2e, and are no longer used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 26.0.0 milestone Jan 20, 2024
@thaJeztah thaJeztah self-assigned this Jan 20, 2024
@thaJeztah
Copy link
Member Author

Flaky test; #47119

=== Failed
=== FAIL: amd64.integration.system TestDiskUsage/empty (0.00s)
    disk_usage_test.go:41: assertion failed: 
        --- du
        +++ →
          types.DiskUsage{
        - 	LayersSize: 4096,
        + 	LayersSize: 0,
          	Images:     {},
          	Containers: {},
          	... // 3 identical fields
          }
        
    --- FAIL: TestDiskUsage/empty (0.00s)

=== FAIL: amd64.integration.system TestDiskUsage (2.69s)

@AkihiroSuda AkihiroSuda merged commit 5ad5334 into moby:master Jan 22, 2024
126 checks passed
@thaJeztah thaJeztah deleted the pkg_homedir_deprecated branch January 22, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

@thaJeztah thaJeztah

Labels
impact/deprecation kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Milestone
26.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thaJeztah @AkihiroSuda