c8d: show the real image creation date when listing images #46719
Conversation
daemon/containerd/image_list.go
Outdated
| @@ -276,10 +279,15 @@ func (i *ImageService) singlePlatformImage(ctx context.Context, contentStore con | |||
| return nil, nil, err | |||
| } | |||
|
|
|||
| created := int64(0) | |||
| if cfg.Created != nil { | |||
| created = cfg.Created.Unix() | |||
There was a problem hiding this comment.
Micro-nit; as we already have a summary var in which we store the image-data, I guess we can avoid the created var if we put this block after it;
if cfg.Created != nil {
summary.Created = cfg.Created.Unix()
}Would there be a need to do && !cfg.Created.IsZero() as well? (not sure)
There was a problem hiding this comment.
I think it's fine to set the Created in the IsZero case, that's actually what the GD case does
There was a problem hiding this comment.
Huhu, want me to change this one too while I'm at it?
moby/daemon/images/image_list.go
Lines 257 to 260 in dcc8020
There was a problem hiding this comment.
Oh! We can; but that's fine for a separate PR, as that's not a new change, right?
My comment was mostly; if we want to; let's do so before merging, to reduce (ever so little) code churn 👍
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
thaJeztah
added
status/2-code-review
area/images
containerd-integration
rumpl
force-pushed
the
c8d-image-created-date
branch
from
37ef049 to
8f756fe
Compare
- What I did
Used the creation date of the imge from the config and not from the containerd metadata,
Also set the
ParentIDto whatever we find in the image labels- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)