Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bridge: Add unit tests for outgoing NAT rules #46677

Merged
merged 1 commit into from
Oct 25, 2023
Merged

bridge: Add unit tests for outgoing NAT rules #46677

merged 1 commit into from
Oct 25, 2023

Conversation

rhansen
Copy link
Contributor

@rhansen rhansen commented Oct 19, 2023 •
edited
Loading

- What I did

Added unit tests for outgoing NAT rules.

This commit is preparation for my work-in-progress fix for #46469.

- How to verify it

make TESTDIRS='github.com/docker/docker/libnetwork/drivers/bridge/...' test-unit

- Description for the changelog

(not needed)

@rhansen rhansen mentioned this pull request Oct 19, 2023
Closed
@thaJeztah thaJeztah requested a review from akerouanton October 19, 2023 07:38
corhere
corhere reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@corhere corhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! More test coverage is always welcome.

libnetwork/drivers/bridge/setup_ip_tables_linux_test.go Outdated Show resolved Hide resolved
libnetwork/drivers/bridge/setup_ip_tables_linux_test.go Show resolved Hide resolved
@rhansen
Add unit tests for outgoing NAT rules
0cf113e 
Signed-off-by: Richard Hansen <rhansen@rhansen.org>
@thaJeztah
Copy link
Member

Test failures look unrelated; I think these are flaky (I'll check if we already have a tracking ticket for them);

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references/local_volume_with_mount_options (2.39s)
    daemon_test.go:513: assertion failed: error is not nil: Error response from daemon: remove test-live-restore-volume-references-local: volume has active mounts
        --- FAIL: TestLiveRestore/volume_references/local_volume_with_mount_options (2.39s)

=== FAIL: amd64.integration.daemon TestLiveRestore/volume_references (17.60s)
    --- FAIL: TestLiveRestore/volume_references (17.60s)

akerouanton
akerouanton approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@akerouanton akerouanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

Let me bring this one in; thanks!

@thaJeztah thaJeztah merged commit fc4d035 into moby:master Oct 25, 2023
104 checks passed
@rhansen rhansen deleted the nat-test branch October 26, 2023 00:00
@thaJeztah thaJeztah added this to the 25.0.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akerouanton akerouanton akerouanton approved these changes

@corhere corhere corhere approved these changes

Assignees
No one assigned
Labels
area/networking area/testing status/2-code-review
Projects
None yet
Milestone
25.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rhansen @thaJeztah @corhere @akerouanton