TestDaemonNoSpaceLeftOnDeviceError: Adjust to snapshotters #46593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
status/2-code-review
area/testing
kind/bugfix
- Pass empty containerd socket which forces the daemon to create a new supervised containerd. Otherwise a global containerd daemon will be used and the pulled image data will be stored in its data directory, instead of the the newly specified `data-root` that has a limited storage capacity. - Don't try to use `vfs` snapshotter, instead use `native` which is containerd's equivalent for `vfs`. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
integration-cli-TestDaemonNoSpaceLeftOnDeviceError-new-containerd
branch
from
e84314e to
1f6bacc
Compare
rumpl
approved these changes
Oct 4, 2023
|
CI failure looks unrelated, but wondering why it fails 🤔 |
|
The failure is caused by Hub randomly returning 500 when requesting an auth token for a non-existing registry. Already reported it and should be fixed soon. |
|
saw the thread on our slack; thanks for raising it! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Made
TestDaemonNoSpaceLeftOnDeviceErrorpass with containerd integration enabled.- How I did it
Pass empty containerd socket which forces the daemon to create a new supervised containerd. Otherwise a global containerd daemon will be used and the pulled image data will be stored in its data directory, instead of the the newly specified
data-rootthat has a limited storage capacity.Don't try to use
vfssnapshotter, instead usenativewhich is containerd's equivalent forvfs.- How to verify it
$ make TEST_FILTER=TestDaemonNoSpaceLeftOnDeviceError TEST_IGNORE_CGROUP_CHECK=1 DOCKER_GRAPHDRIVER=overlayfs TEST_INTEGRATION_USE_SNAPSHOTTER=1 \ test-integration -=== FAIL: amd64.integration-cli TestDockerDaemonSuite/TestDaemonNoSpaceLeftOnDeviceError (4.11s) - docker_cli_daemon_test.go:1641: assertion failed: expression is false: strings.Contains(pullOut, "no space left on device") - check_test.go:589: [d39a69b3940cb] daemon is not started - --- FAIL: TestDockerDaemonSuite/TestDaemonNoSpaceLeftOnDeviceError (4.11s) +=== RUN TestDockerDaemonSuite/TestDaemonNoSpaceLeftOnDeviceError + check_test.go:589: [d17531973e45d] daemon is not started +--- PASS: TestDockerDaemonSuite (7.14s) + --- PASS: TestDockerDaemonSuite/TestDaemonNoSpaceLeftOnDeviceError (7.14s)- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)