c8d/push: Support pushing all tags #46485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
status/2-code-review
area/images
kind/bugfix
vvoland
force-pushed
the
c8d-push-all-tags
branch
from
9c36ac6 to
caedf40
Compare
rumpl
reviewed
Sep 15, 2023
vvoland
force-pushed
the
c8d-push-all-tags
branch
from
caedf40 to
dbade46
Compare
rumpl
approved these changes
Sep 15, 2023
thaJeztah
approved these changes
Sep 15, 2023
Implement missing feature that pushes all tags from the provided local repository. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Add "The push referers to repository X" message which is present in the push output when using the graphdrivers. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
c8d-push-all-tags
branch
from
dbade46 to
7f28190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c8d/push: Support pushing all tags
Implement missing feature that pushes all tags from the provided local
repository.
c8d/push: Add missing message about repository
(a bit unrelated but I decided to include it here since it's only one line and I'm already making changes here)
Add "The push referers to repository X" message which is present in the
push output when using the graphdrivers.
- How to verify it
c8d integration tests CI
$ make TEST_FILTER='TestPushMultipleTags' TEST_IGNORE_CGROUP_CHECK=1 DOCKERCLI_INTEGRATION_VERSION=v24.0.5 DOCKER_GRAPHDRIVER=overlayfs TEST_INTEGRATION_USE_SNAPSHOTTER=1 test-integration ... === RUN TestDockerRegistrySuite/TestPushMultipleTags --- PASS: TestDockerRegistrySuite (0.27s) --- PASS: TestDockerRegistrySuite/TestPushMultipleTags (0.27s)- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)