containerd integration: imageservice: add contexts to various methods #43828

thaJeztah · 2022-07-18T08:52:02Z

In preparation of adding support for image inspect.

- A picture of a cute animal (not mandatory but encouraged)

thaJeztah · 2022-07-18T12:23:55Z

Looks like something is hanging after the tests completed. I opened #43832 to remove the first commit from this PR to make the diff smaller.

thaJeztah · 2022-07-18T15:25:00Z

Looks like something's wrong with this change, but only seeing it in the tests running in Jenkins.

Tests complete succesfully (exit 0), but after that, something is stuck, causing the test to ultimately timeout after 2 hours;

[2022-07-18T13:18:41.311Z] DONE 269 tests, 5 skipped in 2330.442s
[2022-07-18T13:18:41.311Z] ---> Making bundle: .integration-daemon-stop (in bundles/test-integration)
[2022-07-18T13:18:41.311Z] ++++ cat bundles/test-integration/TestDockerDaemonSuite/TestFailedPluginRemove/d5e7843a3a6d8/docker.pid
[2022-07-18T13:18:41.311Z] +++ kill 6961
[2022-07-18T13:18:41.311Z] /go/src/github.com/docker/docker/hack/make/.integration-daemon-stop: line 13: wait: pid 6961 is not a child of this shell
[2022-07-18T13:18:41.311Z] warning: PID 6961 from bundles/test-integration/TestDockerDaemonSuite/TestFailedPluginRemove/d5e7843a3a6d8/docker.pid had a nonzero exit code
[2022-07-18T13:18:41.311Z] ++++ cat bundles/test-integration/docker.pid
[2022-07-18T13:18:41.311Z] +++ kill 9332
[2022-07-18T13:18:41.311Z] +++ /etc/init.d/apparmor stop
[2022-07-18T13:18:41.311Z] Leaving: AppArmorNo profiles have been unloaded.
[2022-07-18T13:18:41.311Z] 
[2022-07-18T13:18:41.311Z] Unloading profiles will leave already running processes permanently
[2022-07-18T13:18:41.311Z] unconfined, which can lead to unexpected situations.
[2022-07-18T13:18:41.311Z] 
[2022-07-18T13:18:41.311Z] To set a process to complain mode, use the command line tool
[2022-07-18T13:18:41.311Z] 'aa-complain'. To really tear down all profiles, run 'aa-teardown'."
[2022-07-18T13:18:41.311Z] +++ true
[2022-07-18T13:18:41.311Z] exiting test-integration
[2022-07-18T13:18:41.311Z] ++ exit 0
[2022-07-18T13:18:41.311Z] 
[2022-07-18T14:28:26.718Z] Sending interrupt signal to process
[2022-07-18T14:28:34.312Z] + c=143
[2022-07-18T14:28:34.312Z] + for job in $(jobs -p)
[2022-07-18T14:28:34.312Z] + wait 14563
[2022-07-18T14:28:34.312Z] + c=1
[2022-07-18T14:28:34.312Z] + for job in $(jobs -p)
[2022-07-18T14:28:34.312Z] + wait 14564
[2022-07-18T14:28:34.312Z] + exit 1
[2022-07-18T14:28:34.312Z] ++ jobs -p
[2022-07-18T14:28:34.312Z] + pids=
[2022-07-18T14:28:34.312Z] + echo 'Remaining pids to kill: []'
[2022-07-18T14:28:34.312Z] Remaining pids to kill: []
[2022-07-18T14:28:34.312Z] + '[' -z '' ']'
[2022-07-18T14:28:34.316Z] script returned exit code 1

thaJeztah · 2022-07-21T14:45:38Z

Looks like we have one integration test "pass" and all the other ones hung;
https://ci-next.docker.com/public/blue/organizations/jenkins/moby/detail/PR-43828/5/pipeline

I'm gonna do a revert of the last commit to try if that makes a change, as I seem to recall it was green at some point before I made that change (but no clue how it would make a difference)

thaJeztah · 2022-07-21T17:51:14Z

nope; that didn't help (didn't really expect it would, but worth trying, just in case)

thaJeztah · 2022-08-08T14:51:32Z

Still hanging; looks like tests complete, but it fails to tear down things (perhaps containers that are kept running?)

Downloaded the "rootless" bundles, and there's at least some tests that contain container logs (which COULD be an indication that those containers weren't cleaned up when the test completed);

.
└── test-integration
    ├── TestCgroupNamespacesBuild
    │   └── d74ceb5abfcd6
    │       └── docker.log
    ├── TestCgroupNamespacesBuildDaemonHostMode
    │   └── dea008988c83c
    │       └── docker.log
    ├── TestCgroupNamespacesRun
    │   └── d442a4aba1497
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 91ccc3f1c0caaf37ed3608e79a293529bff0faf1d71e52bdca18652d6042e430
    │                   └── 91ccc3f1c0caaf37ed3608e79a293529bff0faf1d71e52bdca18652d6042e430-json.log
    ├── TestCgroupNamespacesRunDaemonHostMode
    │   └── d73250aa326a2
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 93ba6230094376fc24113d0da0ef2683a649996c121167a02e6d50b53108f09e
    │                   └── 93ba6230094376fc24113d0da0ef2683a649996c121167a02e6d50b53108f09e-json.log
    ├── TestCgroupNamespacesRunHostMode
    │   └── da32f76749178
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── c4631e2e9da622155cc26796f2780d240354afe714b016f3fa5a7e0aea4e2f13
    │                   └── c4631e2e9da622155cc26796f2780d240354afe714b016f3fa5a7e0aea4e2f13-json.log
    ├── TestCgroupNamespacesRunInvalidMode
    │   └── d44066a0600a4
    │       └── docker.log
    ├── TestCgroupNamespacesRunOlderClient
    │   └── de14cbc0f1806
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── a4f5175452c2186323fd19b0ec2d9be88ec9346897d80f22d36d294d5bc6b51b
    │                   └── a4f5175452c2186323fd19b0ec2d9be88ec9346897d80f22d36d294d5bc6b51b-json.log
    ├── TestCgroupNamespacesRunPrivateMode
    │   └── d4366b784c03a
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 6e17ca01ec5e376026ecdecea63db12e46edec0087e62e57d6e4231d2b45081d
    │                   └── 6e17ca01ec5e376026ecdecea63db12e46edec0087e62e57d6e4231d2b45081d-json.log
    ├── TestCgroupNamespacesRunPrivileged
    │   └── d9bd6f92d66cb
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── c488e93d86149f4b39bddd0bb84b197d9ea9d45636a39cb87cd94b4a9a6efd54
    │                   └── c488e93d86149f4b39bddd0bb84b197d9ea9d45636a39cb87cd94b4a9a6efd54-json.log
    ├── TestCgroupNamespacesRunPrivilegedAndPrivate
    │   └── ded19b3ad97ec
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── b954b5fd6fe6cfd6bb6300640460a6542fec4cba76ccbf149603af7466be472d
    │                   └── b954b5fd6fe6cfd6bb6300640460a6542fec4cba76ccbf149603af7466be472d-json.log
    ├── TestConfigDaemonID
    │   └── d08a4f09817ed
    │       └── docker.log
    ├── TestConfigDaemonLibtrustID
    │   └── d2eddb3f3e146
    │       └── docker.log
    ├── TestConfigDaemonSeccompProfiles
    │   └── d21c0cb3e5c05
    │       └── docker.log
    ├── TestContinueAfterPluginCrash
    │   └── da0d13a8f9e12
    │       └── docker.log
    ├── TestDaemonDNSFallback
    │   └── db7e54ea8f8f3
    │       └── docker.log
    ├── TestDaemonIpcModePrivate
    │   └── d0150fe32b95a
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 7234f802537a0a1841c7a827de9118ebba6e711cbac39598d8bc1d2b11c677d7
    │                   └── 7234f802537a0a1841c7a827de9118ebba6e711cbac39598d8bc1d2b11c677d7-json.log
    ├── TestDaemonRestartIpcMode
    │   └── db6fcb77b8d4a
    │       └── docker.log
    ├── TestDaemonStartWithLogOpt
    │   └── dcf866b389a78
    │       └── docker.log
    ├── TestDiskUsage
    │   └── d9a4146631c97
    │       └── docker.log
    ├── TestExportContainerAfterDaemonRestart
    │   └── d1d14c5f46aac
    │       └── docker.log
    ├── TestGraphdriverPluginV2
    │   └── d64b21f1f83be
    │       └── docker.log
    ├── TestImportExtremelyLargeImageWorks
    │   └── d2fb9647b3529
    │       └── docker.log
    ├── TestInfoAPIWarnings
    │   └── dae3dd9ba4481
    │       └── docker.log
    ├── TestInfoDebug
    │   └── df07ba4c6c9ef
    │       └── docker.log
    ├── TestInfoInsecureRegistries
    │   └── dae9d175a184b
    │       └── docker.log
    ├── TestInfoRegistryMirrors
    │   └── d7d787c241ce9
    │       └── docker.log
    ├── TestPingSwarmHeader
    │   └── d6e619ec68950
    │       └── docker.log
    ├── TestReadPluginNoRead
    │   └── dab324dc6a26f
    │       └── docker.log
    ├── TestRestartDaemonWithRestartingContainer
    │   └── de7f8e7553c0c
    │       └── docker.log
    ├── TestRunWithAlternativeContainerdShim
    │   └── d377c7322e251
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 635cb78091db964d1585ecf3320702caad8bee33a3cd42b0408489523411b9d4
    │                   └── 635cb78091db964d1585ecf3320702caad8bee33a3cd42b0408489523411b9d4-json.log
    ├── TestServicePlugin
    │   └── da5b597e84d93
    │       └── docker.log
    ├── amd64-integration-build-go-test-report.json
    ├── amd64-integration-build-junit-report.xml
    ├── amd64-integration-config-go-test-report.json
    ├── amd64-integration-config-junit-report.xml
    ├── amd64-integration-container-go-test-report.json
    ├── amd64-integration-container-junit-report.xml
    ├── amd64-integration-daemon-go-test-report.json
    ├── amd64-integration-daemon-junit-report.xml
    ├── amd64-integration-image-go-test-report.json
    ├── amd64-integration-image-junit-report.xml
    ├── amd64-integration-internal-termtest-go-test-report.json
    ├── amd64-integration-internal-termtest-junit-report.xml
    ├── amd64-integration-network-go-test-report.json
    ├── amd64-integration-network-ipvlan-go-test-report.json
    ├── amd64-integration-network-ipvlan-junit-report.xml
    ├── amd64-integration-network-junit-report.xml
    ├── amd64-integration-network-macvlan-go-test-report.json
    ├── amd64-integration-network-macvlan-junit-report.xml
    ├── amd64-integration-plugin-authz-go-test-report.json
    ├── amd64-integration-plugin-authz-junit-report.xml
    ├── amd64-integration-plugin-common-go-test-report.json
    ├── amd64-integration-plugin-common-junit-report.xml
    ├── amd64-integration-plugin-go-test-report.json
    ├── amd64-integration-plugin-graphdriver-go-test-report.json
    ├── amd64-integration-plugin-graphdriver-junit-report.xml
    ├── amd64-integration-plugin-junit-report.xml
    ├── amd64-integration-plugin-logging-cmd-discard-go-test-report.json
    ├── amd64-integration-plugin-logging-cmd-discard-junit-report.xml
    ├── amd64-integration-plugin-logging-go-test-report.json
    ├── amd64-integration-plugin-logging-junit-report.xml
    ├── amd64-integration-plugin-volumes-go-test-report.json
    ├── amd64-integration-plugin-volumes-junit-report.xml
    ├── amd64-integration-secret-go-test-report.json
    ├── amd64-integration-secret-junit-report.xml
    ├── amd64-integration-service-go-test-report.json
    ├── amd64-integration-service-junit-report.xml
    ├── amd64-integration-session-go-test-report.json
    ├── amd64-integration-session-junit-report.xml
    ├── amd64-integration-system-go-test-report.json
    ├── amd64-integration-system-junit-report.xml
    ├── amd64-integration-volume-go-test-report.json
    ├── amd64-integration-volume-junit-report.xml
    ├── docker.log
    └── test.log

90 directories, 84 files

And for arm64-integration bundles;

.
└── test-integration
    ├── TestAuthZPluginAPIDenyResponse
    │   └── db1701790993f
    │       └── docker.log
    ├── TestAuthZPluginAllowEventStream
    │   └── d2b0f890e2e4a
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── c24ecc4e63a9490bd093256d1bf4feb3689a1f71de92aa81f71ec201874ccc70
    │                   └── c24ecc4e63a9490bd093256d1bf4feb3689a1f71de92aa81f71ec201874ccc70-json.log
    ├── TestAuthZPluginAllowRequest
    │   └── de08949bc5632
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 1b21ec4a7a1783ad0a6db9b52c9ed2631759de00e122324f77da8ff96b6dce11
    │                   └── 1b21ec4a7a1783ad0a6db9b52c9ed2631759de00e122324f77da8ff96b6dce11-json.log
    ├── TestAuthZPluginDenyRequest
    │   └── d5a0e367a9909
    │       └── docker.log
    ├── TestAuthZPluginDenyResponse
    │   └── d1b54dd3ddd99
    │       └── docker.log
    ├── TestAuthZPluginEnsureLoadImportWorking
    │   └── dca2f2aa70077
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 05c08d92fc39348024f9c9645cf3517e3d87725f049c68daf2c912dce0a099e7
    │                   └── 05c08d92fc39348024f9c9645cf3517e3d87725f049c68daf2c912dce0a099e7-json.log
    ├── TestAuthZPluginEnsureNoDuplicatePluginRegistration
    │   └── d29cc98941176
    │       └── docker.log
    ├── TestAuthZPluginErrorRequest
    │   └── d32da221000a9
    │       └── docker.log
    ├── TestAuthZPluginErrorResponse
    │   └── dec7ea306312b
    │       └── docker.log
    ├── TestAuthZPluginHeader
    │   └── da95cb7f6c4d8
    │       └── docker.log
    ├── TestAuthZPluginTLS
    │   └── dc420ccb0fce4
    │       └── docker.log
    ├── TestAuthZPluginV2NonexistentFailsDaemonStart
    │   └── d09e6822341ef
    │       └── docker.log
    ├── TestAuthzPluginEnsureContainerCopyToFrom
    │   └── d465e11e1f165
    │       └── docker.log
    ├── TestBuildUserNamespaceValidateCapabilitiesAreV2
    │   ├── d89c4ad2da9e4
    │   │   └── docker.log
    │   └── de22c75c682e8
    │       └── docker.log
    ├── TestCgroupNamespacesBuild
    │   └── d9265c6787ead
    │       └── docker.log
    ├── TestCgroupNamespacesBuildDaemonHostMode
    │   └── d8702935151f5
    │       └── docker.log
    ├── TestCgroupNamespacesRun
    │   └── d6ec6cbf54140
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 089708c7950a68cd8dbbdfa98716d6713db0b2ee3bea6897388e078434cbefc9
    │                   └── 089708c7950a68cd8dbbdfa98716d6713db0b2ee3bea6897388e078434cbefc9-json.log
    ├── TestCgroupNamespacesRunDaemonHostMode
    │   └── d2e772ff80867
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── cfb3488d3c75ab7fd47aceea825f4c378c6bbd4fcad8727ff2ab48c40927df8a
    │                   └── cfb3488d3c75ab7fd47aceea825f4c378c6bbd4fcad8727ff2ab48c40927df8a-json.log
    ├── TestCgroupNamespacesRunHostMode
    │   └── dc410f8a5bcb1
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 25a93eead724bea20df0921a6e2cc0a642ee24552dbda4a3e981e69cecede998
    │                   └── 25a93eead724bea20df0921a6e2cc0a642ee24552dbda4a3e981e69cecede998-json.log
    ├── TestCgroupNamespacesRunInvalidMode
    │   └── df48d9cadabf8
    │       └── docker.log
    ├── TestCgroupNamespacesRunOlderClient
    │   └── d5e9274520015
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 0400d36e6fc2e96f882ba1c3924398296b5349bb9a0de4592750b1760d014365
    │                   └── 0400d36e6fc2e96f882ba1c3924398296b5349bb9a0de4592750b1760d014365-json.log
    ├── TestCgroupNamespacesRunPrivateMode
    │   └── d26392b5aaa36
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── cf714356f714d4ce2fdd99776c461b5742cffa93a61a6bb7334a7c0eb32749c8
    │                   └── cf714356f714d4ce2fdd99776c461b5742cffa93a61a6bb7334a7c0eb32749c8-json.log
    ├── TestCgroupNamespacesRunPrivileged
    │   └── d71546ebaecd3
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 55adb3aae3c47255bbe85517dcb1327186454128867234dbd040c67b2d6e6608
    │                   └── 55adb3aae3c47255bbe85517dcb1327186454128867234dbd040c67b2d6e6608-json.log
    ├── TestCgroupNamespacesRunPrivilegedAndPrivate
    │   └── d8c4d6d64695f
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── dc08b0aceace4814620b2a4987930e7a3bf7fa1353702fbf8aaeb489fe1c6a41
    │                   └── dc08b0aceace4814620b2a4987930e7a3bf7fa1353702fbf8aaeb489fe1c6a41-json.log
    ├── TestConfigCreateResolve
    │   └── d5e2ffa509b6f
    │       └── docker.log
    ├── TestConfigDaemonID
    │   └── dfc85efbc7363
    │       └── docker.log
    ├── TestConfigDaemonLibtrustID
    │   └── d52e587265379
    │       └── docker.log
    ├── TestConfigDaemonSeccompProfiles
    │   └── df5c1307e7d84
    │       └── docker.log
    ├── TestConfigInspect
    │   └── d2aca250a70ec
    │       └── docker.log
    ├── TestConfigList
    │   └── db9be2c7487a7
    │       └── docker.log
    ├── TestConfigsCreateAndDelete
    │   └── d74656f0972c5
    │       └── docker.log
    ├── TestConfigsUpdate
    │   └── d53f0dd91fd04
    │       └── docker.log
    ├── TestContainerKillOnDaemonStart
    │   └── db8a0b8cf77eb
    │       └── docker.log
    ├── TestContainerStartOnDaemonRestart
    │   └── df0d59d2508a5
    │       └── docker.log
    ├── TestContinueAfterPluginCrash
    │   └── d85968cda19d1
    │       └── docker.log
    ├── TestCreateJob
    │   └── dc95350dad309
    │       └── docker.log
    ├── TestCreateServiceCapabilities
    │   └── d5efa11ed620f
    │       └── docker.log
    ├── TestCreateServiceConfigFileMode
    │   └── da4ded6270b98
    │       └── docker.log
    ├── TestCreateServiceConflict
    │   └── d504c9f60b951
    │       └── docker.log
    ├── TestCreateServiceMaxReplicas
    │   └── d1ea2c0e74751
    │       └── docker.log
    ├── TestCreateServiceMultipleTimes
    │   └── dec0c7381aa2e
    │       └── docker.log
    ├── TestCreateServiceSecretFileMode
    │   └── d17cb9898f9af
    │       └── docker.log
    ├── TestCreateServiceSysctls
    │   └── df76afafc7549
    │       └── docker.log
    ├── TestCreateWithDuplicateNetworkNames
    │   └── d452eb373d456
    │       └── docker.log
    ├── TestDaemonDNSFallback
    │   └── d3b8eb9f70bef
    │       └── docker.log
    ├── TestDaemonDefaultNetworkPools
    │   └── dcb32e6bcf2cc
    │       └── docker.log
    ├── TestDaemonHostGatewayIP
    │   └── daf20d5af8cb4
    │       └── docker.log
    ├── TestDaemonIpcModePrivate
    │   └── dda6b7020007b
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 0c392eb32031c201ff10fef67e1cfc853a9483d541c8b93bf32efc51c17ed10c
    │                   └── 0c392eb32031c201ff10fef67e1cfc853a9483d541c8b93bf32efc51c17ed10c-json.log
    ├── TestDaemonIpcModePrivateFromConfig
    │   └── d2e812e6fe06e
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── cbca706b997888941b8f3f8462cdeed45cb45a9f64687d0cd89adcc7efbd768d
    │                   └── cbca706b997888941b8f3f8462cdeed45cb45a9f64687d0cd89adcc7efbd768d-json.log
    ├── TestDaemonIpcModeShareable
    │   └── da4c957d828b4
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── ac49240f58a1da7be534df5923f0ed85007379feb4a4d9b33c2e0968d5383a78
    │                   └── ac49240f58a1da7be534df5923f0ed85007379feb4a4d9b33c2e0968d5383a78-json.log
    ├── TestDaemonIpcModeShareableFromConfig
    │   └── dc0c1f2ebcbe1
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── e550a0ea778964ad708862e014b0277113bb243429cada7e4ed1ac694fb73598
    │                   └── e550a0ea778964ad708862e014b0277113bb243429cada7e4ed1ac694fb73598-json.log
    ├── TestDaemonProxy
    │   ├── command-line_options
    │   │   └── d9d16d53687ec
    │   │       └── docker.log
    │   ├── configuration_file
    │   │   └── d00c9fb410724
    │   │       └── docker.log
    │   ├── conflicting_options
    │   │   └── d72e86a7b6d1b
    │   │       └── docker.log
    │   ├── environment_variables
    │   │   └── d884c153da06d
    │   │       └── docker.log
    │   └── reload_sanitized
    │       └── db346fb1dd9cb
    │           └── docker.log
    ├── TestDaemonRestartIpcMode
    │   └── da9e4a8509779
    │       └── docker.log
    ├── TestDaemonRestartKillContainers
    │   ├── live-restore=false
    │   │   ├── container_created_should_not_be_restarted
    │   │   │   ├── kill-daemon
    │   │   │   │   └── de9771faaa214
    │   │   │   │       └── docker.log
    │   │   │   └── stop-daemon
    │   │   │       └── d98be0cd97f7a
    │   │   │           └── docker.log
    │   │   ├── container_with_restart=always
    │   │   │   ├── kill-daemon
    │   │   │   │   └── dbcd574a5dd8a
    │   │   │   │       └── docker.log
    │   │   │   └── stop-daemon
    │   │   │       └── d866b94e80920
    │   │   │           └── docker.log
    │   │   ├── container_with_restart=always_and_with_healthcheck
    │   │   │   ├── kill-daemon
    │   │   │   │   └── d3a17cbcf8285
    │   │   │   │       └── docker.log
    │   │   │   └── stop-daemon
    │   │   │       └── d2a77fdc42237
    │   │   │           └── docker.log
    │   │   └── container_without_restart_policy
    │   │       ├── kill-daemon
    │   │       │   └── ddd2ac4b9d3af
    │   │       │       └── docker.log
    │   │       └── stop-daemon
    │   │           └── deb94c6046390
    │   │               └── docker.log
    │   └── live-restore=true
    │       ├── container_created_should_not_be_restarted
    │       │   ├── kill-daemon
    │       │   │   └── deb7ce877dba6
    │       │   │       └── docker.log
    │       │   └── stop-daemon
    │       │       └── d6b1348a05477
    │       │           └── docker.log
    │       ├── container_with_restart=always
    │       │   ├── kill-daemon
    │       │   │   └── d9e54c7c93312
    │       │   │       └── docker.log
    │       │   └── stop-daemon
    │       │       └── de8bea3362970
    │       │           └── docker.log
    │       ├── container_with_restart=always_and_with_healthcheck
    │       │   ├── kill-daemon
    │       │   │   └── df2b1bb318fef
    │       │   │       └── docker.log
    │       │   └── stop-daemon
    │       │       └── df96c3747959e
    │       │           └── docker.log
    │       └── container_without_restart_policy
    │           ├── kill-daemon
    │           │   └── d09af2a012517
    │           │       └── docker.log
    │           └── stop-daemon
    │               └── d7a30549a41f6
    │                   └── docker.log
    ├── TestDaemonRestartWithExistingNetwork
    │   └── d5afbdf34824b
    │       └── docker.log
    ├── TestDaemonRestartWithExistingNetworkWithDefaultPoolRange
    │   └── df712d0828b51
    │       └── docker.log
    ├── TestDaemonRestartWithLiveRestore
    │   └── dab949eff7aba
    │       └── docker.log
    ├── TestDaemonStartWithLogOpt
    │   └── de6e42cda3a6c
    │       └── docker.log
    ├── TestDaemonWithBipAndDefaultNetworkPool
    │   └── d23784fb1b020
    │       └── docker.log
    ├── TestDiskUsage
    │   └── d5972c74c0730
    │       └── docker.log
    ├── TestDockerNetworkConnectAlias
    │   └── d3460325eb4e7
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               ├── 543a6ce48990e36c43ce33e1f7024ac9615c1d8568fa2355615f872b58043ed9
    │               │   └── 543a6ce48990e36c43ce33e1f7024ac9615c1d8568fa2355615f872b58043ed9-json.log
    │               └── 8069963666a95929d161b67c2e431d62443d371c4de3da6e74c96c27b7846bda
    │                   └── 8069963666a95929d161b67c2e431d62443d371c4de3da6e74c96c27b7846bda-json.log
    ├── TestDockerNetworkMacvlan
    │   ├── d13fb0e276667
    │   │   └── docker.log
    │   ├── d2a6d4ed3480f
    │   │   ├── docker.log
    │   │   └── root
    │   │       └── containers
    │   │           ├── b64502d977203fd981aa1017897cbd1c948e44f970e2985df16eca25285b6654
    │   │           │   └── b64502d977203fd981aa1017897cbd1c948e44f970e2985df16eca25285b6654-json.log
    │   │           ├── bd72dc502375bca00ece1fcab591d92840689d960f8f995d12e33874adff8ff8
    │   │           │   └── bd72dc502375bca00ece1fcab591d92840689d960f8f995d12e33874adff8ff8-json.log
    │   │           ├── c578405d166a97fc89315d17e422d5df6dd2a90c20242675280ac0f54cb093b2
    │   │           │   └── c578405d166a97fc89315d17e422d5df6dd2a90c20242675280ac0f54cb093b2-json.log
    │   │           └── de194e9094fca71b59581d0217e00c721761e7859cc787f1ed76cd361ec23517
    │   │               └── de194e9094fca71b59581d0217e00c721761e7859cc787f1ed76cd361ec23517-json.log
    │   ├── d6860a8f35453
    │   │   └── docker.log
    │   ├── d8755739810e9
    │   │   ├── docker.log
    │   │   └── root
    │   │       └── containers
    │   │           ├── 30817b38097ffab7b4f95f16788cbd085fdcd4b646c971eb785eb129b505b8fb
    │   │           │   └── 30817b38097ffab7b4f95f16788cbd085fdcd4b646c971eb785eb129b505b8fb-json.log
    │   │           └── 5840a41f3d6db2246b469a7b7d685f36979f05cdd1451e3e34c9107dfecfaa61
    │   │               └── 5840a41f3d6db2246b469a7b7d685f36979f05cdd1451e3e34c9107dfecfaa61-json.log
    │   ├── da108b379e94d
    │   │   ├── docker.log
    │   │   └── root
    │   │       └── containers
    │   │           └── 8a3505e295e6713c81f2c693b7492fbfb1469e8ac3a7bfc34f72ef49f54e9984
    │   │               └── 8a3505e295e6713c81f2c693b7492fbfb1469e8ac3a7bfc34f72ef49f54e9984-json.log
    │   └── dd9dcd42958e8
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               ├── 7c1f1e6cab105861bf7d4089a0de55f820f8dbc3db36ee93579cce39417cb673
    │               │   └── 7c1f1e6cab105861bf7d4089a0de55f820f8dbc3db36ee93579cce39417cb673-json.log
    │               └── bc22628b0ba722cf4f8a9c92cad62e2bf454fb80d8225621594cd132861dc5f8
    │                   └── bc22628b0ba722cf4f8a9c92cad62e2bf454fb80d8225621594cd132861dc5f8-json.log
    ├── TestDockerNetworkMacvlanPersistance
    │   └── d16a7cdaf6547
    │       └── docker.log
    ├── TestDockerNetworkReConnect
    │   └── d291e77a5a2c5
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 547d4527e77a661554c09a1ccc38975662c846d4c553cc24b6e224a746916910
    │                   └── 547d4527e77a661554c09a1ccc38975662c846d4c553cc24b6e224a746916910-json.log
    ├── TestExportContainerAfterDaemonRestart
    │   └── d779002284d61
    │       └── docker.log
    ├── TestExternalGraphDriver
    │   └── d9465aaca6d3c
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 57007d2a1d15152b978da71662d5ed41ce6a2c0ec49c2c69c9a041414eae7283
    │                   └── 57007d2a1d15152b978da71662d5ed41ce6a2c0ec49c2c69c9a041414eae7283-json.log
    ├── TestHostIPv4BridgeLabel
    │   └── d8320cccbda89
    │       └── docker.log
    ├── TestInfoAPIWarnings
    │   └── d4db8bf03672c
    │       └── docker.log
    ├── TestInfoDebug
    │   └── d18333b5489c9
    │       └── docker.log
    ├── TestInfoInsecureRegistries
    │   └── d4c7776b5e474
    │       └── docker.log
    ├── TestInfoRegistryMirrors
    │   └── d548a3bd8bdfd
    │       └── docker.log
    ├── TestInspect
    │   └── d6ba83f6448b3
    │       └── docker.log
    ├── TestInspectNetwork
    │   └── d262f010d71d3
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               ├── 8fb020871aa1be3850c4a3883d358026bcd4c7f7b53f445b2ea52fb0aa32fd0d
    │               │   └── 8fb020871aa1be3850c4a3883d358026bcd4c7f7b53f445b2ea52fb0aa32fd0d-json.log
    │               └── 95e300b58f8ccf8fe7aa2cc37394c82982dd5d7d1c2e5b9ae3ccaf03e734b22e
    │                   └── 95e300b58f8ccf8fe7aa2cc37394c82982dd5d7d1c2e5b9ae3ccaf03e734b22e-json.log
    ├── TestPingSwarmHeader
    │   └── dcd714605fc31
    │       └── docker.log
    ├── TestPluginInstall
    │   └── with_insecure
    │       └── d60fbd50bdae8
    │           └── docker.log
    ├── TestPluginWithDevMounts
    │   └── dcdecb5348315
    │       └── docker.log
    ├── TestPluginsWithRuntimes
    │   └── d5101e1c9870f
    │       └── docker.log
    ├── TestReadPluginNoRead
    │   └── df4c8e92b44c7
    │       └── docker.log
    ├── TestReplicatedJob
    │   └── d42b238d65574
    │       └── docker.log
    ├── TestRestartDaemonWithRestartingContainer
    │   └── d0be0ad459883
    │       └── docker.log
    ├── TestRunContainerWithBridgeNone
    │   └── ded0d49678426
    │       └── docker.log
    ├── TestRunWithAlternativeContainerdShim
    │   └── d1cfc4b555ab5
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 64ba7ede92aa3d993a87d2b992077728e9f25880cd5b89af40490294a05c2201
    │                   └── 64ba7ede92aa3d993a87d2b992077728e9f25880cd5b89af40490294a05c2201-json.log
    ├── TestSecretCreateResolve
    │   └── dc265049880e9
    │       └── docker.log
    ├── TestSecretInspect
    │   └── deaa703d40269
    │       └── docker.log
    ├── TestSecretList
    │   └── de6a86ae08ed6
    │       └── docker.log
    ├── TestSecretsCreateAndDelete
    │   └── deb77d08a1fd9
    │       └── docker.log
    ├── TestSecretsUpdate
    │   └── d3b5ea40afae6
    │       └── docker.log
    ├── TestServiceCreateInit
    │   ├── daemonInitDisabled
    │   │   └── d5d0a61158d94
    │   │       └── docker.log
    │   └── daemonInitEnabled
    │       └── dcd72f45f9289
    │           └── docker.log
    ├── TestServiceUpdateConfigs
    │   └── dd68bda8e43ce
    │       └── docker.log
    ├── TestServiceUpdateLabel
    │   └── d1e1336bca09a
    │       └── docker.log
    ├── TestServiceUpdateNetwork
    │   └── da12bb2a07987
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── dc21aff2785a118e409479113ffe738efd57b10b2b0c62e5f9679140de2ef84f
    │                   └── dc21aff2785a118e409479113ffe738efd57b10b2b0c62e5f9679140de2ef84f-json.log
    ├── TestServiceUpdatePidsLimit
    │   └── d1fb6152b3b60
    │       └── docker.log
    ├── TestServiceUpdateSecrets
    │   └── d919a245567b5
    │       └── docker.log
    ├── TestServiceWithDataPathPortInit
    │   ├── d00aa3a7e2cd7
    │   │   ├── docker.log
    │   │   └── root
    │   │       └── containers
    │   │           └── 5d9a3e18a0d6dfd3514cd25c8e39bf515eda5bc3d350db5b6fd9c330ce8e3b0f
    │   │               └── 5d9a3e18a0d6dfd3514cd25c8e39bf515eda5bc3d350db5b6fd9c330ce8e3b0f-json.log
    │   └── dd3fa1a478eea
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 3fc649d4cf3b0f61b0339c4d0549a52e67f0e27892bb80e6651df78506cdacb8
    │                   └── 3fc649d4cf3b0f61b0339c4d0549a52e67f0e27892bb80e6651df78506cdacb8-json.log
    ├── TestServiceWithDefaultAddressPoolInit
    │   └── da1b64a3016e2
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 7c55a4e55a7e26bb972779ba60d3492a745ad60968f2ccf93c66d8eb4c80eef1
    │                   └── 7c55a4e55a7e26bb972779ba60d3492a745ad60968f2ccf93c66d8eb4c80eef1-json.log
    ├── TestServiceWithPredefinedNetwork
    │   └── d2e387c42a4bf
    │       ├── docker.log
    │       └── root
    │           └── containers
    │               └── 575bed79e6ec04aaca411e6f76919eafb985ca60f83f44638c4e3d24cc4d3cae
    │                   └── 575bed79e6ec04aaca411e6f76919eafb985ca60f83f44638c4e3d24cc4d3cae-json.log
    ├── TestTemplatedConfig
    │   └── daec2e2e60853
    │       └── docker.log
    ├── TestTemplatedSecret
    │   └── d5cb8d8d002a9
    │       └── docker.log
    ├── TestUpdateReplicatedJob
    │   └── dd2961fd946d0
    │       └── docker.log
    ├── arm64-integration-build-go-test-report.json
    ├── arm64-integration-build-junit-report.xml
    ├── arm64-integration-config-go-test-report.json
    ├── arm64-integration-config-junit-report.xml
    ├── arm64-integration-container-go-test-report.json
    ├── arm64-integration-container-junit-report.xml
    ├── arm64-integration-daemon-go-test-report.json
    ├── arm64-integration-daemon-junit-report.xml
    ├── arm64-integration-image-go-test-report.json
    ├── arm64-integration-image-junit-report.xml
    ├── arm64-integration-internal-termtest-go-test-report.json
    ├── arm64-integration-internal-termtest-junit-report.xml
    ├── arm64-integration-network-go-test-report.json
    ├── arm64-integration-network-ipvlan-go-test-report.json
    ├── arm64-integration-network-ipvlan-junit-report.xml
    ├── arm64-integration-network-junit-report.xml
    ├── arm64-integration-network-macvlan-go-test-report.json
    ├── arm64-integration-network-macvlan-junit-report.xml
    ├── arm64-integration-plugin-authz-go-test-report.json
    ├── arm64-integration-plugin-authz-junit-report.xml
    ├── arm64-integration-plugin-common-go-test-report.json
    ├── arm64-integration-plugin-common-junit-report.xml
    ├── arm64-integration-plugin-go-test-report.json
    ├── arm64-integration-plugin-graphdriver-go-test-report.json
    ├── arm64-integration-plugin-graphdriver-junit-report.xml
    ├── arm64-integration-plugin-junit-report.xml
    ├── arm64-integration-plugin-logging-cmd-discard-go-test-report.json
    ├── arm64-integration-plugin-logging-cmd-discard-junit-report.xml
    ├── arm64-integration-plugin-logging-go-test-report.json
    ├── arm64-integration-plugin-logging-junit-report.xml
    ├── arm64-integration-plugin-volumes-go-test-report.json
    ├── arm64-integration-plugin-volumes-junit-report.xml
    ├── arm64-integration-secret-go-test-report.json
    ├── arm64-integration-secret-junit-report.xml
    ├── arm64-integration-service-go-test-report.json
    ├── arm64-integration-service-junit-report.xml
    ├── arm64-integration-session-go-test-report.json
    ├── arm64-integration-session-junit-report.xml
    ├── arm64-integration-system-go-test-report.json
    ├── arm64-integration-system-junit-report.xml
    ├── arm64-integration-volume-go-test-report.json
    ├── arm64-integration-volume-junit-report.xml
    ├── docker.log
    └── test.log

351 directories, 205 files

In preparation of adding support for image inspect. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah added status/2-code-review area/images labels Jul 18, 2022

thaJeztah added this to the v-next milestone Jul 18, 2022

thaJeztah requested a review from tonistiigi as a code owner July 18, 2022 08:52

This was referenced Jul 18, 2022

add support for image inspect with containerd-integration #43818

Merged

containerd integration: restructure code to match existing implementation #43831

Merged

thaJeztah force-pushed the containerd_contexts branch from 364637d to f762cb8 Compare July 18, 2022 11:26

thaJeztah mentioned this pull request Jul 18, 2022

daemon/images: rename variables that collided with imports #43832

Merged

thaJeztah force-pushed the containerd_contexts branch from f762cb8 to 55cac38 Compare July 18, 2022 12:27

thaJeztah force-pushed the containerd_contexts branch from 55cac38 to bc641c6 Compare July 19, 2022 10:49

thaJeztah added the containerd-integration Issues and PRs related to containerd integration label Jul 21, 2022

thaJeztah force-pushed the containerd_contexts branch from bc641c6 to 9c2197f Compare July 21, 2022 14:50

thaJeztah force-pushed the containerd_contexts branch 2 times, most recently from 8ae85d0 to e448c82 Compare August 8, 2022 10:41

thaJeztah mentioned this pull request Aug 8, 2022

daemon: rename variables that collided with imports #43934

Merged

thaJeztah force-pushed the containerd_contexts branch 2 times, most recently from b3acd9a to f460ccf Compare August 8, 2022 11:17

thaJeztah force-pushed the containerd_contexts branch from f460ccf to 3478507 Compare August 8, 2022 16:45

thaJeztah mentioned this pull request Aug 9, 2022

containerd integration: imageservice: add contexts to various methods (step 1) #43939

Merged

thaJeztah force-pushed the containerd_contexts branch from 3478507 to 527217a Compare August 24, 2022 20:01

thaJeztah mentioned this pull request Sep 1, 2022

manage image inspect data in backend #44080

Closed

imageservice: add contexts to various methods

b1d50a6

In preparation of adding support for image inspect. Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the containerd_contexts branch from 527217a to b1d50a6 Compare September 7, 2022 17:41

vvoland mentioned this pull request Oct 27, 2022

imageservice: Add context to various methods #44365

Merged

thaJeztah closed this Nov 3, 2022

thaJeztah deleted the containerd_contexts branch November 3, 2022 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

containerd integration: imageservice: add contexts to various methods #43828

containerd integration: imageservice: add contexts to various methods #43828

thaJeztah commented Jul 18, 2022

thaJeztah commented Jul 18, 2022

thaJeztah commented Jul 18, 2022

thaJeztah commented Jul 21, 2022 •

edited

Loading

thaJeztah commented Jul 21, 2022

thaJeztah commented Aug 8, 2022

containerd integration: imageservice: add contexts to various methods #43828

containerd integration: imageservice: add contexts to various methods #43828

Conversation

thaJeztah commented Jul 18, 2022

thaJeztah commented Jul 18, 2022

thaJeztah commented Jul 18, 2022

thaJeztah commented Jul 21, 2022 • edited Loading

thaJeztah commented Jul 21, 2022

thaJeztah commented Aug 8, 2022

thaJeztah commented Jul 21, 2022 •

edited

Loading