Add an integration/internal/container helper package #36266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdemeester
force-pushed
the
integration-container-helper
branch
from
ae95f86 to
8278c63
Compare
dnephin
reviewed
Feb 9, 2018
| } | ||
|
|
||
| func Create(t *testing.T, ctx context.Context, client client.APIClient, ops ...func(*TestContainerConfig)) string { | ||
| config := &TestContainerConfig{ |
There was a problem hiding this comment.
Should we t.Helper() in these so the error gets reported from the caller?
| ) | ||
|
|
||
| type TestContainerConfig struct { | ||
| Name string |
There was a problem hiding this comment.
I wish we had this struct (and ops) for the actual client package! I guess we can look at doing that later
There was a problem hiding this comment.
That's definitely sthg we should do 👼 (It's now on my todo 😛)
vdemeester
force-pushed
the
integration-container-helper
branch
from
8278c63 to
c4054ff
Compare
vdemeester
changed the title
vdemeester
force-pushed
the
integration-container-helper
branch
from
c4054ff to
0958efb
Compare
To help creating/running/… containers using the client for test integration.
This should make test more readable and reduce duplication a bit.
Usage example
```
// Create a default container named foo
id1 := container.Create(t, ctx, client, container.WithName("foo"))
// Run a default container with a custom command
id2 := container.Run(t, ctx, client, container.WithCmd("echo", "hello world"))
```
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
integration-container-helper
branch
from
0958efb to
0bb7d42
Compare
This was referenced Feb 10, 2018
This was referenced Feb 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #36265
To help creating/running/… containers using the client for test integration.
This should make test more readable and reduce duplication a bit.
Usage example
This replace
runSimpleContainerandcreateSimpleContainer👼Signed-off-by: Vincent Demeester vincent@sbr.pm