Fix "--node-generic-resource" singular/plural #36125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daemon flags that can be specified multiple times use singlar names for flags, but plural names for the configuration file. To make the daemon configuration know how to correlate the flag with the corresponding configuration option, `opt.NewNamedListOptsRef()` should be used instead of `opt.NewListOptsRef()`. Commit 6702ac5 attempted to fix the daemon not corresponding the flag with the configuration file option, but did so by changing the name of the flag to plural. This patch reverts that change, and uses `opt.NewNamedListOptsRef()` instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Thanks for looking into this @thaJeztah ! |
|
ping @AkihiroSuda @dnephin PTAL |
This was referenced Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daemon flags that can be specified multiple times use singlar names for flags, but plural names for the configuration file.
To make the daemon configuration know how to correlate the flag with the corresponding configuration option,
opt.NewNamedListOptsRef()should be used instead ofopt.NewListOptsRef().Commit 6702ac5 (#35970) attempted to fix the daemon not corresponding the flag with the configuration file option, but did so by changing the name of the flag to plural.
This patch reverts that change, and uses
opt.NewNamedListOptsRef()instead.ping @vdemeester @AkihiroSuda @RenaudWasTaken