[17.04.x] deprecation and changelog updates #31848
Conversation
CHANGELOG.md
Outdated
| * Wait for OOBE to prevent crashing during host update [#31054](https://github.com/docker/docker/pull/31054) | ||
| * Block pulling Windows images on non-Windows daemons [#29001](https://github.com/docker/docker/pull/29001) | ||
|
|
||
| ### Deprecation | ||
|
|
||
| * Removal of the email from `docker login` [#26868](https://github.com/docker/docker/pull/26868) |
There was a problem hiding this comment.
Alternatively, we should revert this change in 17.04 and move it to 17.06
docs/deprecated.md
Outdated
| @@ -266,7 +266,7 @@ of the `--changes` flag that allows to pass `Dockerfile` commands. | |||
|
|
|||
| ### Interacting with V1 registries | |||
|
|
|||
| **Disabled By Default In Release: v17.04** | |||
| **Disabled By Default In Release: v17.05** | |||
There was a problem hiding this comment.
Wondering if we should only deprecate in quarterly releases, i.e. move this to 17.06? If so we should update the deprecation policy accordingly. We can mark features deprecated in monthly releases, but remove them only in quarterly releases wdyt?
There was a problem hiding this comment.
Let me move it to 17.06; we can decide on the change in policy separate from that
thaJeztah
force-pushed
the
17.04.0-changelog-updates
branch
2 times, most recently
from
54ae11a to
9fcee8d
Compare
thaJeztah
changed the title
CHANGELOG.md
Outdated
| + Add `--filter enabled=true` for `docker plugin ls` [#28627](https://github.com/docker/docker/pull/28627) | ||
| + Add `--format` to `docker service ls` [#28199](https://github.com/docker/docker/pull/28199) | ||
| + Add `publish` and `expose` filter for `docker ps --filter` [#27557](https://github.com/docker/docker/pull/27557) | ||
| * Support multiple service IDs on `docker service ps` [#25234](https://github.com/docker/docker/pull/25234) | ||
| + Allow swarm join with `--availability=drain` [#24993](https://github.com/docker/docker/pull/24993) | ||
| * Removal of the email from `docker login` [#26868](https://github.com/docker/docker/pull/26868) | ||
| + Allow `plugin` management commands to address plugins by ID instead of name [#29222](https://github.com/docker/docker/pull/29222) |
There was a problem hiding this comment.
I removed this one already, as @anusha-ragunathan pointed out, the feature was already here, this PR only adds a test
There was a problem hiding this comment.
oh, right, let me remove the impact/changelog label :)
CHANGELOG.md
Outdated
| * Wait for OOBE to prevent crashing during host update [#31054](https://github.com/docker/docker/pull/31054) | ||
| * Block pulling Windows images on non-Windows daemons [#29001](https://github.com/docker/docker/pull/29001) | ||
|
|
||
| ### Deprecation |
There was a problem hiding this comment.
@tonistiigi pointed out in the last PR that it's usually used to announce new depreciation, not the actual removal.
There was a problem hiding this comment.
hm, ok, wondering if it's better to have a separate section to more clearly point it out (it's easily overlooked and may be important when upgrading from a previous version)
open to suggestions though
thaJeztah
force-pushed
the
17.04.0-changelog-updates
branch
2 times, most recently
from
5b7a698 to
5072c7c
Compare
- Interacting with V1 registries is not yet disabled by default, so moving the deprecation version - Added various entries to the changelog, and moved some to a different section Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
17.04.0-changelog-updates
branch
from
5072c7c to
2387faa
Compare
|
LGTM |
[17.04.x] deprecation and changelog updates (cherry picked from commit f15f593) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
ping @vieux PTAL