Allow uppercase characters in image reference hostname #20175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes restores the pre-Docker 1.10 behavior of allowing uppercase characters in registry hostnames. Note that this only applies to hostnames, not remote image names. Previous versions also prohibited uppercase letters after the hostname, but Docker 1.10 extended this to the hostname itself. - Vendor updated distribution docker/1.10 branch. - Add a check to "normalize" that rejects remote names with uppercase letters. - Add test cases to TestTagValidPrefixedRepo and TestTagInvalidUnprefixedRepo Fixes: moby#20056 Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
|
LGTM |
|
LGTM for 1.10.1 But for 1.11 we really need to get rid of these hacks and force-lowercase everything. |
|
Job: Docker-PRs-WoW-TP4 FAILED: ---
Current directory is /c/gopath/src/github.com/docker/docker
---------------------------------------------------------------------------
-----------------------------------------------
ERROR: Failed with exitcode 1 at Wed Feb 10 08:14:05 CUT 2016.
-----------------------------------------------
INFO: Tidying up at end of run
INFO: Nuking /d/CI
INFO: Zapped successfully
INFO: End of cleanup
INFO: Ended at Wed Feb 10 08:14:06 CUT 2016 (0m 2s)
Build step 'Execute shell' marked build as failure
[PostBuildScript] - Execution post build scripts.
[docker] $ sh -xe D:\temp\hudson6599106779158892175.sh
+ set +e
+ set +x
INFO: End of cleanup
Notifying endpoint 'HTTP:https://leeroy.dockerproject.org/notification/jenkins'
---
|
cpuguy83
added a commit
that referenced
this pull request
Feb 10, 2016
Allow uppercase characters in image reference hostname
|
Since this was against 1.10, should I open a separate PR against master to apply equivalent changes? The vendor update won't apply cleanly to master, since it is on a later version of distribution.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes restores the pre-Docker 1.10 behavior of allowing
uppercase characters in registry hostnames.
Note that this only applies to hostnames, not remote image names.
Previous versions also prohibited uppercase letters after the hostname,
but Docker 1.10 extended this to the hostname itself.
letters.
TestTagInvalidUnprefixedRepo
Fixes: #20056
cc @dmcgowan @tonistiigi @tiborvass