Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add send, recv, and x32 so we can install i386 pkgs on amd64 #19432

Merged
merged 1 commit into from
Jan 19, 2016
Merged

add send, recv, and x32 so we can install i386 pkgs on amd64 #19432

merged 1 commit into from
Jan 19, 2016

Conversation

jessfraz
Copy link
Contributor

makes sure this works:

docker run --rm -it debian:jessie bash
# dpkg --add-architecture i386
# apt-get update && apt-get install curl:i386
# curl -sSL ifconfig.co

before patch
curl: (55) Send failure: Operation not permitted

after patch
WORKS!

@jessfraz
add send, recv, and x32 so we can install i386 pkgs on amd64
308eff9 
Signed-off-by: Jessica Frazelle <acidburn@docker.com>
@jessfraz jessfraz added this to the 1.10.0 milestone Jan 19, 2016
@justincormack
Copy link
Contributor

Ah send, recv: have checked the other socketcalls again, these are not present on x86_64, but they are present as socketcalls on x86, but probably werent being used in what I tested as they are legacy (at least Musl libc just uses sendto with null args for send). I can't see anything else in that situation.

Congratulations on adding x32, Linux's least useful architecture.

LGTM.

@unclejack
Copy link
Contributor

@jfrazelle Last time I've looked, we were able to cross-compile Go binaries for i386. Would you like to add an integration-cli test which tries to run a i386 binary on amd64?

@justincormack
Copy link
Contributor

@unclejack to be fair, almost all i386 binaries did run before this change, just not Debian's version of curl, so that would not have caught this. I am looking at further tests for seccomp changes for the next release. Not that having a test would do any harm.

@cpuguy83
Copy link
Member

LGTM

1 similar comment
@tiborvass
Copy link
Contributor

LGTM

tiborvass added a commit that referenced this pull request Jan 19, 2016
@tiborvass
Merge pull request #19432 from jfrazelle/fix-x32
30e42a2 
add send, recv, and x32 so we can install i386 pkgs on amd64
@tiborvass tiborvass merged commit 30e42a2 into moby:master Jan 19, 2016
@jessfraz jessfraz deleted the fix-x32 branch January 19, 2016 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/security/seccomp
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jessfraz @justincormack @unclejack @cpuguy83 @tiborvass @GordonTheTurtle