Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendoring miekg/dns @ 75e6e86cc601825c5dbcd4e0c209eab180997cd7 #19426

Merged
merged 1 commit into from
Jan 19, 2016
Merged

Vendoring miekg/dns @ 75e6e86cc601825c5dbcd4e0c209eab180997cd7 #19426

merged 1 commit into from
Jan 19, 2016

Conversation

sanimej
Copy link

@sanimej sanimej commented Jan 18, 2016

  • Fixes the issue of Shutdown() not working, resulting in hung
    goroutines
  • Fixes libnetwork #878

Signed-off-by: Santhosh Manohar santhosh@docker.com

Vendoring miekg/dns @ 75e6e86cc601825c5dbcd4e0c209eab180997cd7
bccf653 
- Fixes the issue of Shutdown() not working, resulting in hung
  goroutines

Signed-off-by: Santhosh Manohar <santhosh@docker.com>
@mavenugo mavenugo added this to the 1.10.0 milestone Jan 18, 2016
@sanimej sanimej mentioned this pull request Jan 18, 2016
Closed
@icecrime
Copy link
Contributor

LGTM

Ping @tiborvass @thaJeztah

@tiborvass
Copy link
Contributor

LGTM

@thaJeztah
Copy link
Member

Thanks!

@mavenugo
Copy link
Contributor

@icecrime @thaJeztah sorry... wrong label at the wrong phase :). thanks for fixing it.

@thaJeztah
Copy link
Member

Flaky test?

02:18:17 FAIL: docker_cli_run_test.go:2258: DockerSuite.TestRunSlowStdoutConsumer
02:18:17 
02:18:17 docker_cli_run_test.go:2279:
02:18:17     c.Fatalf("Expected %d, got %d", expected, n)
02:18:17 ... Error: Expected 4096000, got 3712692

vdemeester added a commit that referenced this pull request Jan 19, 2016
@vdemeester
Merge pull request #19426 from sanimej/restart
011ca5f 
Vendoring miekg/dns @ 75e6e86cc601825c5dbcd4e0c209eab180997cd7
@vdemeester vdemeester merged commit 011ca5f into moby:master Jan 19, 2016
@sanimej sanimej deleted the restart branch August 15, 2016 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
7 participants
@sanimej @icecrime @tiborvass @thaJeztah @mavenugo @vdemeester @GordonTheTurtle