Don't error out on plugin err with json #19131
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GordonTheTurtle
added
status/0-triage
dco/no
|
ping @runcom |
We don't want to error out when there is a json unmarshal error since the `old way` will cause this to error. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_plugin_error_handling
branch
from
ca80495 to
279dd09
Compare
GordonTheTurtle
removed
the
dco/no
that string can be a json payload 😄 This change LGTM. |
|
make sense, LGTM |
runcom
added a commit
that referenced
this pull request
Jan 8, 2016
Don't error out on plugin err with json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to error out when there is a json unmarshal error since
the
old waywill cause this to error.I'm also a little suspect of this new handling now that I've messed with it.
HTTP statuses other than
200should only be used for protocol level issues, which don't really need to encode a json message since it can just write a string to the body.