Do not initialize the networking routes when netController is not enabled. #17128
+38
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
force-pushed
the
network_controller_enabled
branch
from
00f2da0 to
0afdc0b
Compare
|
LGTM :) |
|
ping @mavenugo PTAL |
|
I'm going to make some adjustments here to improve the UX in the client when the networking controller is disabled. |
|
LGTM. |
This will prevent the api from trying to serve network requests in systems where libnetwork is not enabled, returning 404 responses in any case. Signed-off-by: David Calavera <david.calavera@gmail.com>
calavera
force-pushed
the
network_controller_enabled
branch
from
0afdc0b to
eb982e7
Compare
calavera
changed the title
|
I made a change to return a nicer message to the user. This is what happens when the network controller is not initialized: |
|
Nice! Still LGTM |
|
LGTM |
tiborvass
added a commit
that referenced
this pull request
Oct 19, 2015
Do not initialize the networking routes when netController is not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the api from trying to serve network requests in
systems where libnetwork is not enabled, returning 404 responses in any
case.
This is a better fix than #17036 for windows.
Closes #17036.
/cc @jhowardmsft, @mavenugo
Signed-off-by: David Calavera david.calavera@gmail.com