-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix description of filters
param for /volumes and /networks.
#17127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes moby#17091 Signed-off-by: Tobias Gesellchen <tobias@gesellix.de>
Added 1.9.0 milestone as the related issue is on it too. /ping @thaJeztah @gesellix could you edit the content of your PR to add "Fixes #17091" so that once merged, the issue is closed automagically 😉 |
@vdemeester I did already :-) |
@gesellix oh in the commit message, didn't see it 😅. Good then, nvm 👍 |
Good catch! LGTM |
LGTM |
cpuguy83
added a commit
that referenced
this pull request
Oct 19, 2015
docs: fix description of `filters` param for /volumes and /networks.
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tiborvass
pushed a commit
to tiborvass/docker
that referenced
this pull request
Nov 3, 2015
Add back the "old" networksettings fields that were removed, but added back to maintain backward compatibility, in moby#17538 Update network endpoint responses, with updated response introduced in; moby#17536 Added changes to v1.22 that were applied to the v1.21 / v1.20 docs after the API bump(s); moby#17085 moby#17127 moby#13707 Also fixed some mixed tab/spaces indentation and Markdown formatting issues (causing code-blocks to be rendered incorrectly) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 286fe69) Conflicts: docs/reference/api/docker_remote_api_v1.22.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #17091
Signed-off-by: Tobias Gesellchen tobias@gesellix.de