Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the content type is json when calling exec start. #17125

Merged
merged 1 commit into from
Oct 19, 2015

Conversation

calavera
Copy link
Contributor

Supersedes #16399.

Signed-off-by: David Calavera david.calavera@gmail.com

@runcom
Copy link
Member

runcom commented Oct 16, 2015

LGTM

@vdemeester
Copy link
Member

LGTM 🐲 (assuming it's green 💚)

@calavera calavera force-pushed the check_exec_start_json branch from e1c9dd9 to e8774ee Compare October 16, 2015 23:09
@runcom
Copy link
Member

runcom commented Oct 17, 2015

@calavera build failure

@vdemeester
Copy link
Member

api/client/hijack.go:130: undefined: hijackWithContentType

Signed-off-by: David Calavera <david.calavera@gmail.com>
@calavera calavera force-pushed the check_exec_start_json branch from e8774ee to 45dc57f Compare October 19, 2015 15:47
@calavera
Copy link
Contributor Author

@runcom, @vdemeester I fixed that compilation error and everything is green, can you take another look?

@runcom
Copy link
Member

runcom commented Oct 19, 2015

reLGTM

runcom added a commit that referenced this pull request Oct 19, 2015
Check the content type is json when calling exec start.
@runcom runcom merged commit bb085b7 into moby:master Oct 19, 2015
@calavera calavera deleted the check_exec_start_json branch October 19, 2015 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants