-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix 16326] Bash completion syntax error on OSX #16345
Conversation
Signed-off-by: Harald Albers <github@albersweb.de>
ping @tianon @jfrazelle |
@AlexZeitler @gauravgoyal |
@albers Sorry, MBP died and is out of office for repair 😭 |
This LGTM, but I think warrants at least a basic "functional" test on a real Mac. 👍 |
who has a mac anymore :P On Wed, Sep 16, 2015 at 9:44 AM, Alexander Zeitler <notifications@github.com
|
@jfrazelle It's just for testing Docker issues on OS X 😬 . If I need to get work done, I'm on Ubuntu anyway 😛 |
lol |
[Fix 16326] Bash completion syntax error on OSX
👍 |
@calavera wow, someone with a Mac! Can you please tell me what |
@calavera the animation is cool. how did you create it? |
@albers I'm pretty sure this is useless, but this is the output:
PS: I use licecap to create quick gifs like that: http://www.cockos.com/licecap |
@calavera Sorry, I asked for the wrong command. Can you please check the output of |
@albers, I ran that shoot on my Mac, and the result is this (BTW, I had the same error, and the commit 0a5aac1 seems to have fixed it).
|
Thanks for telling me, @juvenal. |
I see @calavera also has a newer version, possibly installed through homebrew? fwiw; $ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin14)
Copyright (C) 2007 Free Software Foundation, Inc.
$ shopt -p extglob
shopt -s extglob |
@thaJeztah Thanks! |
ref: #16326
On systems where the extglob shell option is not set by default, bash completion would issue an error when sourcing the Docker completion file, see #16326.
The code dealing with this condition (in
_docker
function) was insufficient.I verified the script in the
albers/bash-completion-mac
image with and without the extglob option set.