daemon/events: let Log be [slightly] blocking #16316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With go1.5's concurrency, the use of a goroutine in Log'ing events was causing the resulting events to not be in order. Signed-off-by: Vincent Batts <vbatts@redhat.com>
GordonTheTurtle
added
the
dco/no
|
also, reverting #15702 (386aefb) per @LK4D4 request (https://botbot.me/freenode/docker-maintainers/msg/49788744/) |
This reverts commit 386aefb. Signed-off-by: Vincent Batts <vbatts@redhat.com>
vbatts
force-pushed
the
vbatts-events
branch
from
3a17b5a to
fc77ea7
Compare
GordonTheTurtle
removed
the
dco/no
|
LGTM |
|
I tested this on go1.5.1 as well |
|
LGTM |
1 similar comment
|
LGTM |
calavera
added a commit
that referenced
this pull request
Sep 16, 2015
daemon/events: let Log be [slightly] blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With go1.5's concurrency, the use of a goroutine in Log'ing events was
causing the resulting events to not be in order.
ping @LK4D4
Signed-off-by: Vincent Batts vbatts@redhat.com