Fix container register failed during daemon start and then start the container #16275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -315,6 +315,8 @@ func (daemon *Daemon) restore() error { | |||
|
|
|||
| if err := daemon.Register(container); err != nil { | |||
| logrus.Debugf("Failed to register container %s: %s", container.ID, err) | |||
There was a problem hiding this comment.
I think the log level should be "ERROR" instead of "DEBUG".
Otherwise we have to ask the user to switch on the debug flag to report such kind of bugs, which is a bit inconvenient.
There was a problem hiding this comment.
@mountkin Agree . thanks :-)
coolljt0725
force-pushed
the
fix_register_failed_and_start
branch
from
21beca9 to
b4841dd
Compare
…e container Signed-off-by: Lei Jitang <leijitang@huawei.com>
|
@coolljt0725 , Thanks for whipping up this patch. I look forward to using this to fix my problem (#14199). Can you point me to the guide on how to build this branch locally so I can test this on my system? How risky is it to run MASTER ? I suppose I could apply this patch to the |
|
@ChrisRut I think we should wait the Maintainers to review and confirm this is the right fix. :-) |
|
Fair enough 🔜... |
|
LGTM |
|
LGTM |
runcom
added a commit
that referenced
this pull request
Sep 15, 2015
Fix container register failed during daemon start and then start the container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lei Jitang leijitang@huawei.com
The container register failed during daemon starting should not be
started even if it has a restart policy
Fixes #14199