Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry: Change default endpoint on windows to a windows-specific one #14970

Merged
merged 1 commit into from
Jul 31, 2015
Merged

registry: Change default endpoint on windows to a windows-specific one #14970

merged 1 commit into from
Jul 31, 2015

Conversation

tiborvass
Copy link
Contributor

Signed-off-by: Tibor Vass tibor@docker.com

Ping @icecrime @dmp42

@tiborvass tiborvass force-pushed the windows-registry-endpoint branch from cc21153 to b670871 Compare July 24, 2015 20:29
@tiborvass
Copy link
Contributor Author

This disables entirely the offical v1 registry on windows. Let me know if that's not desired.

@icecrime
Copy link
Contributor

LGTM 👍

@dmp42
Copy link
Contributor

dmp42 commented Jul 24, 2015

LGTM

stevvooe
stevvooe reviewed Jul 24, 2015
View reviewed changes
registry/consts_windows.go
@@ -0,0 +1,7 @@
// +build windows

package registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a big comment explaining why this was done and that it is temporary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@tiborvass tiborvass force-pushed the windows-registry-endpoint branch 3 times, most recently from 1b7dee3 to 529e4de Compare July 25, 2015 00:52
@calavera
Copy link
Contributor

is https://ms-tp3.registry-1.docker.io up and working? I'm guessing all tests on windows that depend on the registry will fail if that host is not ready.

@tiborvass
Copy link
Contributor Author

@calavera the CI doesn't test Windows daemon yet, so that codepath is never executed on the CI.

@tiborvass tiborvass force-pushed the windows-registry-endpoint branch from 529e4de to 323bc97 Compare July 27, 2015 17:33
@calavera
Copy link
Contributor

okay, it makes sense. Carry on! 👍

@tiborvass tiborvass force-pushed the windows-registry-endpoint branch 2 times, most recently from c0e8ef9 to 456471a Compare July 27, 2015 18:04
registry: Change default endpoint on windows to a windows-specific one
4a92b8a 
Signed-off-by: Tibor Vass <tibor@docker.com>
@tiborvass tiborvass force-pushed the windows-registry-endpoint branch from 456471a to 4a92b8a Compare July 30, 2015 18:52
tiborvass added a commit that referenced this pull request Jul 31, 2015
@tiborvass
Merge pull request #14970 from tiborvass/windows-registry-endpoint
ad96fc3 
registry: Change default endpoint on windows to a windows-specific one
@tiborvass tiborvass merged commit ad96fc3 into moby:master Jul 31, 2015
@thaJeztah
Copy link
Member

@tiborvass I added some impact labels, but please review them, if I added the correct ones

@tiborvass
Copy link
Contributor Author

@thaJeztah I don't think this should have any impact at all. This is solely for the windows daemon which is not released yet.

@thaJeztah
Copy link
Member

@tiborvass doh! I read "blocking v1 registry", didn't really think "daemon".

yeah, I doubt many will be affected 😄

@tiborvass tiborvass deleted the windows-registry-endpoint branch July 17, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/distribution impact/changelog impact/cli impact/deprecation platform/windows status/4-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tiborvass @icecrime @dmp42 @calavera @thaJeztah @stevvooe @GordonTheTurtle