Configure TLS for private v2 registry mirrors. #14829
Conversation
| if err != nil { | ||
| return &tls.Config{}, err | ||
| } | ||
| tlsConfig, err := s.TlsConfig(mirrorUrl.Host) |
There was a problem hiding this comment.
you can simply return s.TlsConfig(...)
|
LGTM after fixing the error returns. |
|
I wonder what happens with v1 mirrors |
|
Can you clarify what the original behavior was that was causing problems? |
|
EDIT: I agree with you that it should be clarified in the commit / PR description. |
|
without calling the |
|
@tiborvass to clarify my understanding, the issue is that it was not using certificates from |
@tiborvass To your comment above the section, I don't think v1 mirrors should even be included in that list. V1 mirrors do not mirror the index and those endpoints should only be indexes. |
|
@RichardScothern feel free to remove v1 mirrors in that LookupEndpoints list. |
RichardScothern
force-pushed
the
registry-tls
branch
from
a9f64f4 to
195fb4f
Compare
|
LGTM |
|
Let's make it clearer in the commit message and PR description that this is fixing private v2 mirrors and public v2 mirrors were working just fine. |
If a registry mirror is using TLS, ensure that certs for it are picked up from /etc/docker/certs.d Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
V1 mirrors do not mirror the index and those endpoints should only be indexes. Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
RichardScothern
force-pushed
the
registry-tls
branch
from
195fb4f to
6b36a48
Compare
RichardScothern
changed the title
|
LGTM |
Configure TLS for private v2 registry mirrors.
Signed-off-by: Richard Scothern richard.scothern@gmail.com
Closes #14823
cc @tiborvass @dmcgowan