Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update in Kitematic OS support #14195

Merged
merged 1 commit into from
Jul 3, 2015
Merged

update in Kitematic OS support #14195

merged 1 commit into from
Jul 3, 2015

Conversation

ch3lo
Copy link
Contributor

@ch3lo ch3lo commented Jun 26, 2015

Kitematic now support Windows

@@ -289,7 +289,7 @@ system
* [Docker Compose](https://github.com/docker/compose) (formerly Fig):
Define and run multi-container apps
* [Kitematic](https://github.com/kitematic/kitematic): The easiest way to use
Docker on a Mac
Docker on a Mac and Windows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove "a" here? (So Docker on Mac and Windows)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Waiting for Jenkins build

@thaJeztah
Copy link
Member

Thanks for this, @ch3lo

I added one small correction, LGTM if that is corrected

ping @fredlf @jamtur01 @SvenDowideit @moxiegirl

@jamtur01
Copy link
Contributor

jamtur01 commented Jul 2, 2015

LGTM if corrected too.

@ch3lo ch3lo force-pushed the master branch 2 times, most recently from f2eb177 to 6bdee8f Compare July 2, 2015 22:39
@thaJeztah
Copy link
Member

@ch3lo thanks for addressing, can you squash your commits so that there's only a single commit? You can find instructions for that here; https://docs.docker.com/project/work-issue/#pull-and-rebase-frequently

Let us know if you need help! ❤️

@SvenDowideit
Copy link
Contributor

LGTM when squashed.

Kitematic now support Windows

Signed-off-by: Marcelo Salazar R <chelosalazar@gmail.com>
@thaJeztah
Copy link
Member

Thank you, @ch3lo!

(janky is running)

thaJeztah added a commit that referenced this pull request Jul 3, 2015
update in Kitematic OS support
@thaJeztah thaJeztah merged commit bca3264 into moby:master Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants