Fix error when trying to delete an image due to a bad container #13527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // on would fail with a "Prefix can't be empty" error even | ||
| // though the bad container has nothing to do with the image | ||
| // we're trying to delete. | ||
| logrus.Errorf("Container %q has no image associted with it!", container.ID) |
I ran into a situation where I was trying:
`docker rmi busybox`
and it kept failing saying:
`could not find image: Prefix can't be empty`
While I have no idea how I got into this situation, it turns out this is
error message is from `daemon.canDeleteImage()`. In that func we loop over
all containers checking to see if they're using the image we're trying to
delete. In my case though, I had a container with no ImageID. So the code
would die tryig to find that image (hence the "Prefix can't be empty" err).
This would stop all processing despite the fact that the container we're
checking had nothing to do with 'busybox'.
My change logs the bad situation in the logs and then skips that container.
There's no reason to fail all `docker rmi ...` calls just because of one
bad container.
Will continue to try to figure out how I got a container w/o an ImageID
but as of now I have no idea, I didn't do anything but normal docker cli
commands.
Signed-off-by: Doug Davis <dug@us.ibm.com>
duglin
force-pushed
the
FixImagesPrefixNotFound
branch
from
996631e to
71a4990
Compare
|
In case people are wondering why this situation isn't a problem in other areas of the code, it actually is. While debugging I found several other flows where this error is generated, but in each case the error was eventually ignored and processing continued. So, in that respect this fix is consistent with those other cases I came across. |
|
LGTM |
|
ping @jfrazelle @LK4D4 |
|
is this for 1.7 |
|
@jfrazelle I haven't heard of other people complaining about seeing this error so I don't think its critical for 1.7, despite it being very safe. |
|
LGTM |
jessfraz
pushed a commit
that referenced
this pull request
May 29, 2015
Fix error when trying to delete an image due to a bad container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation where I was trying:
docker rmi busyboxand it kept failing saying:
could not find image: Prefix can't be emptyWhile I have no idea how I got into this situation, it turns out this is
error message is from
daemon.canDeleteImage(). In that func we loop overall containers checking to see if they're using the image we're trying to
delete. In my case though, I had a container with no ImageID. So the code
would die trying to find that image (hence the "Prefix can't be empty" err).
This would stop all processing despite the fact that the container we're
checking had nothing to do with 'busybox'.
My change logs the bad situation in the logs and then skips that container.
There's no reason to fail all
docker rmi ...calls just because of onebad container.
Will continue to try to figure out how I got a container w/o an ImageID
but as of now I have no idea, I didn't do anything but normal docker cli
commands.
Signed-off-by: Doug Davis dug@us.ibm.com