Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vet errors #10101

Merged
merged 3 commits into from
Jan 14, 2015
Merged

Fix vet errors #10101

merged 3 commits into from
Jan 14, 2015

Conversation

LK4D4
Copy link
Contributor

@LK4D4 LK4D4 commented Jan 14, 2015

No description provided.

LK4D4 added 3 commits January 14, 2015 14:01
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
@jessfraz
Copy link
Contributor

we should add vet to the tests, i like vet

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jan 14, 2015

@jfrazelle Yup, I'm too, I wonder how to suppress:

pkg/devicemapper/devmapper_wrapper.go:230: possible misuse of unsafe.Pointer

Maybe @vbatts knows

@jessfraz
Copy link
Contributor

is there a way to misuse unsafe.Pointer, i figured that was the point of unsafe haha

@jessfraz
Copy link
Contributor

LGTM

1 similar comment
@crosbymichael
Copy link
Contributor

LGTM

crosbymichael added a commit that referenced this pull request Jan 14, 2015
@crosbymichael crosbymichael merged commit 3118ccc into moby:master Jan 14, 2015
@LK4D4 LK4D4 deleted the fix_vet_errors branch January 14, 2015 23:26
@vbatts
Copy link
Contributor

vbatts commented Jan 21, 2015

late, but whateva.

I've researched this. I'm not sure there is a better way to do this.
unsafe.Pointer is the actual thing used for representing a void* in C.
There is an allusion to the runtime detecting the misuse of an
unsafe.Pointer and crashing itself, but this is proper use of it ...

On Wed, Jan 14, 2015 at 5:41 PM, Alexander Morozov <notifications@github.com

wrote:

@jfrazelle https://github.com/jfrazelle Yup, I'm too, I wonder how to
suppress:

pkg/devicemapper/devmapper_wrapper.go:230: possible misuse of unsafe.Pointer

Maybe @vbatts https://github.com/vbatts knows


Reply to this email directly or view it on GitHub
#10101 (comment).

@LK4D4
Copy link
Contributor Author

LK4D4 commented Jan 21, 2015

@vbatts Hmm, maybe we should post issue to golang tracker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants