modprobe when needed #1040
Merged
modprobe when needed #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| logrus.Warnf("Running modprobe bridge br_netfilter failed with message: %s, error: %v", out, err) | ||
| } | ||
| } | ||
| if err := iptables.FirewalldInit(); err != nil { |
There was a problem hiding this comment.
By moving FirewalldInit() under EnableIPTables, this might impact other drivers inadvertently that uses IPTables for its operation (such as Overlay in Kernel < 3.16).
This should be moved to iptables package. WDYT ?
- in bridge driver modprobe for br_netfilter only if EnableIPTables==true - move FirewalldInit() to iptables pakcage Init() - move modprobe for nf_nat and xt_conntrack in iptables.initCheck() Signed-off-by: Alessandro Boch <aboch@docker.com>
|
LGTM |
1 similar comment
|
LGTM |
|
Hello, A question in lines of "bridge under /proc/sys/net/ being unavailable". Is there a way to modprobe in docker or any other solution to make it available? Any inputs greatly appreciated! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to moby/moby#16964
Signed-off-by: Alessandro Boch aboch@docker.com