Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack: do not cache some stages on release #3543

Merged
merged 1 commit into from
Feb 9, 2023
Merged

hack: do not cache some stages on release #3543

merged 1 commit into from
Feb 9, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 27, 2023 •
edited
Loading

fixes #3542

Disables cache on release for some stages so packages are always installed and up to date.

@crazy-max crazy-max requested a review from tonistiigi January 27, 2023 21:45
@crazy-max crazy-max marked this pull request as ready for review January 27, 2023 21:45
@crazy-max crazy-max mentioned this pull request Jan 27, 2023
Closed
thaJeztah
thaJeztah reviewed Jan 27, 2023
View reviewed changes
hack/images Outdated Show resolved Hide resolved
@crazy-max crazy-max changed the title hack: do not cache buildkit-export stage on ci ci: disable cache on release Jan 31, 2023
@crazy-max crazy-max force-pushed the ci-nocache branch 6 times, most recently from 33d29bf to 54aaab9 Compare January 31, 2023 13:23
@crazy-max crazy-max added this to the v0.11.3 milestone Jan 31, 2023
jedevc
jedevc reviewed Feb 1, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the ci-nocache branch 2 times, most recently from b00fb23 to 1985212 Compare February 1, 2023 16:14
tonistiigi
tonistiigi reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to disable cache for releases completely. The cache is already scoped. Having these separate codepaths makes it possible that the CI works fine, we tag a release and that release does not build at all.

@crazy-max crazy-max marked this pull request as draft February 1, 2023 16:50
@crazy-max crazy-max changed the title ci: disable cache on release hack: do not cache some stages on release Feb 2, 2023
@crazy-max crazy-max added area/hack building buildkit itself area/ci labels Feb 2, 2023
@crazy-max crazy-max marked this pull request as ready for review February 2, 2023 19:24
@crazy-max
hack: do not cache some stages on release
9a0760a 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 10fdc26 into moby:master Feb 9, 2023
@crazy-max crazy-max deleted the ci-nocache branch February 9, 2023 18:15
@tonistiigi tonistiigi mentioned this pull request Feb 13, 2023
Merged
@crazy-max crazy-max mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah left review comments

@jedevc jedevc jedevc approved these changes

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
area/ci area/hack building buildkit itself
Projects
None yet
Milestone
v0.11.3
Development

Successfully merging this pull request may close these issues.

Vulnerabilities issues with latest 0.11.2 image
4 participants
@crazy-max @tonistiigi @thaJeztah @jedevc