Reduce memory footprint (issue #854) #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bind() removed from unbox() and applyPatches()/applySnapshot() - lazy middlewares/patchSubscribers/snapshotSubscribers/disposers arrays allocation
|
Merged! Thanks :) |
mweststrate
added a commit
that referenced
this pull request
Jun 18, 2018
Reduce memory footprint (issue #854)
lookfirst
reviewed
Jun 19, 2018
| this.snapshotSubscribers.splice(0) | ||
| this.patchSubscribers.splice(0) | ||
| if (this.patchSubscribers) this.patchSubscribers.splice(0) | ||
| if (this.snapshotSubscribers) this.snapshotSubscribers.splice(0) |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day!
This PR is intended to be merged over current master and become part of 2.0 branch as it makes MST a little bit faster without any visible changes. Those who will not be able migrate to 3.0 as soon as it's released could benefit from this one.
Three points were backported from my previous work:
All tests are passing. I've also tried to use it in project at work - no issues were found.
Comparison (prod builds, master@left, pr@right):
I didn't dare to backport other minor changes as those give insignificant impact, but may cause bugs.