Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{pre,post}ProcessSnapshot on compose #1013

Merged
merged 2 commits into from
Sep 14, 2018
Merged

{pre,post}ProcessSnapshot on compose #1013

merged 2 commits into from
Sep 14, 2018

Conversation

theRealScoobaSteve
Copy link

Closes #613

xaviergonz
xaviergonz approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@xaviergonz xaviergonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

packages/mobx-state-tree/__tests__/core/type-system.test.ts Outdated
composedOf: types.array(types.string)
})
const x = LoggableCar.create({})
expect(x.composedOf).toContain("CompositionTracker")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also check the order by using a single toEqual([....])? or the array indexes and toBe

@mweststrate
Copy link
Member

Agreed, this can be merged. Thanks for finding & fixing @theRealScoobaSteve!

@xaviergonz
Copy link
Contributor

merging!

@xaviergonz xaviergonz merged commit 23d946d into mobxjs:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xaviergonz xaviergonz xaviergonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theRealScoobaSteve @mweststrate @xaviergonz