Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frozen and applySnapshot [bug] #634

Closed
maxguzenski opened this issue Jan 31, 2018 · 5 comments
Closed

frozen and applySnapshot [bug] #634

maxguzenski opened this issue Jan 31, 2018 · 5 comments
Labels
bug Confirmed bug help/PR welcome Help/Pull request from contributors to fix the issue is welcome

Comments

@maxguzenski
Copy link

maxguzenski commented Jan 31, 2018 •
edited
Loading

When use applySnapshot it set a optional t.frozen to undefined...
Is this expected ?

const Model = types.model('model', {
  field: t.optional(t.frozen, {})
})

const m = Model.create({})
m.field == {} 

applySnapshot(m, {})
m.field == undefined
@elite174
Copy link

elite174 commented Feb 7, 2018

Try this.
https://jsfiddle.net/43a9bepv/

@maxguzenski
Copy link
Author

Your link is using a old mobx-state-tree version, where there is no bug... try this:

https://mattiamanzati.github.io/mobx-state-tree-playground/#src=import%20React%20from%20%22react%22%0Aimport%20%7B%20types%2C%20applySnapshot%20%7D%20from%20%22mobx-state-tree%22%0A%0Aconst%20Model%20%3D%20types.model('model'%2C%20%7B%0A%20%20field%3A%20types.optional(types.frozen%2C%20%7B%7D)%0A%7D)%0A%0Aconst%20m%20%3D%20Model.create(%7B%7D)%0Aconsole.log(m.field%20%3D%3D%20%7B%7D)%20%0A%0AapplySnapshot(m%2C%20%7B%7D)%0Aconsole.log(m.field%20%3D%3D%20undefined)%0A%2F*%20const%20m%20%3D%20Model.create(%7B%7D)%0Aconsole.log(m.field%20%3D%3D%20%7B%0AapplySnapshot(m%2C%20%7B%7D)%0Aconsole.log(getSnapshot(m))%0Aconsole.log(m.field%20%3D%3D%20undefined)%20*%2F

@maxguzenski maxguzenski changed the title frozen and applySnapshot frozen and applySnapshot [bug] Feb 7, 2018
@aretecode
Copy link
Contributor

this is the same issue I saw here #347

@robinfehr robinfehr mentioned this issue Mar 21, 2018
Closed
@robinfehr robinfehr added bug Confirmed bug help/PR welcome Help/Pull request from contributors to fix the issue is welcome labels Mar 21, 2018
@robinfehr
Copy link
Contributor

PR welcome. it's now on the todo list.

@mweststrate mweststrate mentioned this issue May 4, 2018
Closed
@SirbyAlive SirbyAlive mentioned this issue Jun 1, 2018
Merged
mweststrate added a commit that referenced this issue Jun 8, 2018
@mweststrate
Merge pull request #842 from SirbyAlive/634-fix-undefined-optional-fr…
5993c6c 
…ozen-to-default-value

#634 fix optional frozen to return default value if undefined
@mweststrate
Copy link
Member

Fix released as 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bug help/PR welcome Help/Pull request from contributors to fix the issue is welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maxguzenski @mweststrate @aretecode @robinfehr @elite174