Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH, MRG] remove duplicated code, add deprecation for subplot indexing [skip ci #88

Merged
merged 6 commits into from
Mar 17, 2022
Merged

[ENH, MRG] remove duplicated code, add deprecation for subplot indexing [skip ci #88

merged 6 commits into from
Mar 17, 2022

Conversation

alexrockhill
Copy link
Contributor

@alexrockhill alexrockhill commented Mar 17, 2022 •
edited
Loading

This brings mne-connectivity up to date with changes to connectivity plotting and prevents getting out of sync in the future. Adds a few features from mne-tools/mne-python#10439.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@alexrockhill
Copy link
Contributor Author

Not sure what's going on with Circle, it looks like some kind of permissions error but otherwise this should be good

cc @adam2392

@alexrockhill
Copy link
Contributor Author

Since Circle isn't running, I just ran the examples locally and got some deprecation warnings so I fixed those too

@alexrockhill alexrockhill mentioned this pull request Mar 17, 2022
Merged
adam2392
adam2392 reviewed Mar 17, 2022
View reviewed changes
Copy link
Member

@adam2392 adam2392 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexrockhill! Looks like circleCI running now.

Will take a look at:

examples/mixed_source_space_connectivity.py and examples/mne_inverse_label_connectivity.py when circleCI done.

@alexrockhill
Copy link
Contributor Author

Yep, I fixed the workflow issue. I just fixed some overlapping text as well, but that's all I wanted to change

@alexrockhill
Copy link
Contributor Author

It looks good on the previous ones but probably wait until circle finishes https://497-369628653-gh.circle-artifacts.com/0/dev/auto_examples/mne_inverse_label_connectivity.html

@adam2392 adam2392 merged commit a9b46ed into mne-tools:main Mar 17, 2022
@adam2392
Copy link
Member

Thanks @alexrockhill !

@alexrockhill
Copy link
Contributor Author

Oops, one last thing there was a code-block that got messed up.

tsbinns pushed a commit to tsbinns/mne-connectivity that referenced this pull request Dec 15, 2023
@alexrockhill
[ENH, MRG] remove duplicated code, add deprecation for subplot indexi…
91aaf63 
…ng [skip ci (mne-tools#88)

* remove duplicated code, add deprecation for subplot indexing [skip ci
]

* update whatsnew

* fix deprecation warnings

* fix github workflow deprecation

* fix doc

* fix overlapping text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adam2392 adam2392 adam2392 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrockhill @adam2392