[Refactor] Rename Engine to MLCEngine #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieFRuan
force-pushed
the
pr-0521-rename-engine
branch
from
808108b to
2a9237c
Compare
CharlieFRuan
added a commit
that referenced
this pull request
May 22, 2024
This version bump is breaking as we renamed APIs. ### Changes The only two changes are: - Renamed all `Engine` to `MLCEngine` - #408 - See https://github.com/mlc-ai/web-llm/pull/408/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80 fo the full list of changes - To accommodate this breaking change, control-F `Engine` (with same capitalization) and replace with `MLCEngine` should suffice - Renamed ServiceWorker classes: - #403 - WebServiceWorker -> ServiceWorker - ServiceWorker -> ExtensionServiceWorker ### WASM Version v0_2_34 as no change is required. ### TVMjs TVMjs compiled at apache/tvm@a5862a5, with no change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We rename all
EnginetoMLCEngineto:Engine, especially when users do wildcard importingTo accommodate this breaking change, control-F
Engine(with same capitalization) and replace withMLCEngineshould suffice