[SLIM] Make web-llm compatible with SLIM models #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieFRuan
changed the title
CharlieFRuan
force-pushed
the
pr-slimify
branch
from
7293de9
to
2089d1c
Compare
tqchen
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make web-llm runtime compatible with SLIM models, a new workflow in mlc-llm. This depends on apache/tvm#16198 and is currently not backward-compatible with non-SLIM model, since we introduced a new global function to TVM.
The main difference is reading the metadata and loading the parameters.
Besides, we now read stop_tokens from the conversation template instead of relying on metadata.