Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log cleanup #116

Merged
merged 6 commits into from
Aug 20, 2018
Merged

log cleanup #116

merged 6 commits into from
Aug 20, 2018

Conversation

mkenney
Copy link
Owner

@mkenney mkenney commented Aug 18, 2018

Change type

What types of changes does your code introduce to go-chrome?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please explain here)

Checklist

  • I have read the CONTRIBUTING guidelines.
  • Lint and unit tests pass locally with my changes.
  • I have created tests which fail without the change (if possible) and prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).

What does this implement/fix? Please explain these changes.

  • clarify vague error messages
  • cleanup log message log levels
  • implement log data structure

Does this close any currently open issues?

#111

Any relevant logs, error output, etc?

Any other comments?

@mkenney mkenney added this to the v1.0.0 milestone Aug 18, 2018
@mkenney mkenney added the bug label Aug 18, 2018
@mkenney mkenney self-assigned this Aug 18, 2018
@mkenney mkenney merged commit c65c730 into master Aug 20, 2018
@mkenney mkenney deleted the logger branch August 20, 2018 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant