Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Polish translation for built-in themes #3613

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Add Polish translation for built-in themes #3613

merged 3 commits into from
Apr 9, 2024

Conversation

s-rakowski
Copy link
Contributor

Hello, I added .po files with Polish language strings for the two built-in themes.
Unfortunately, lunr-languages doesn't support Polish but I think this is out of scope for this pull request.

I also noticed that in the "ReadTheDocs" theme, in the footer the word "theme" is not added as a translatable string:

Built with MkDocs using a theme provided by Read the Docs.

Therefore it gets translated to:

Zbudowano przy użyciu MkDocs z pomocą theme dostarczonego przez Read the Docs.

Would it be OK to modify footer.html within this PR so that the word "theme" gets added to messages.pot?

@pawamoy
Copy link
Contributor

pawamoy commented Mar 28, 2024

Thanks for the translations!

Would it be OK to modify footer.html within this PR so that the word "theme" gets added to messages.pot?

That sounds like a reasonable request.

@kamilkrzyskow
Copy link

kamilkrzyskow commented Mar 29, 2024 •
edited
Loading

Overall LGTM 👍 Some opinionated comments below, you don't have to implement them ✌️

msgid "Page not found"
msgstr "Strony nie znaleziono"

"Nie znaleziono strony" would be nicer to read.

#: mkdocs/themes/mkdocs/base.html:126
msgid "Previous"
msgstr "Wstecz"

If this is the previous/next page button, you can use the translation for that "Poprzednia strona" etc., as it would be nicer to read.
This doesn't apply to ReadTheDocs as "Previous" is used in other contexts than page switching.

msgstr "Dokumentacja zbudowana przy użyciu %(mkdocs_link)s."

Similar to the example shown in the OP, you could add flavour words to make it nicer to read / more grammatically correct e.g. "przy użyciu pakietu MkDocs"

msgstr "W tym miejscu możesz przeszukiwać dokumenty. Wpisz swoje kryteria wyszukiwania poniżej."
msgstr "Wpisz tutaj kryteria wyszukiwania"

Even though it's correct I feel like "frazę wyszukiwania" would be nicer to read, no need to keep it plural.

msgstr "Nie znaleziono żadnych wyników"

Unneccessary adjective "żadnych"

@s-rakowski
Copy link
Contributor Author

Thank you for the feedback!

That sounds like a reasonable request.

I added this in 6ff8e57. Hopefully this is OK.

Overall LGTM 👍 Some opinionated comments below, you don't have to implement them ✌️

Thanks. I tried to follow your comments, however I left the translations for "Previous" and "Next" in the MkDocs theme as is, because there wasn't much free space in the header.

@s-rakowski s-rakowski marked this pull request as ready for review March 30, 2024 23:11
@oprypin oprypin added this to the 1.6.0 milestone Apr 9, 2024
oprypin
oprypin approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!:

Would it be OK to modify footer.html within this PR so that the word "theme" gets added to messages.pot?

@oprypin oprypin merged commit 20bad19 into mkdocs:master Apr 9, 2024
17 checks passed
@oprypin oprypin mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@s-rakowski @pawamoy @kamilkrzyskow @oprypin