Apply planned changes to File.page and not_in_nav
#3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the prior plan #3381 (comment)
to decide whether a file in included when generating the implicit nav. Fixes #3336
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error when setting File.page to a type other than Page
As per the prior plan Keep the prior behavior of overwriting File.page #3381 (comment)
When
navconfig is not specified, apply file inclusionto decide whether a file in included when generating the implicit nav.
Fixes Setting
InclusionLevel.NOT_IN_NAVstill adds pages tonav#3336