Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin events that persist across builds in mkdocs serve #2972

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Add plugin events that persist across builds in mkdocs serve #2972

merged 2 commits into from
Sep 14, 2022

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Sep 11, 2022 •
edited
Loading

"One-time events" on_startup(command: str, dirty: bool), on_shutdown.

Their presence also shows that a plugin wants to persist across builds. Otherwise they will be re-created, to not change any existing behavior.

This was referenced Sep 11, 2022
Closed
Closed
@oprypin oprypin force-pushed the onshut branch 3 times, most recently from 7d98088 to d2f910e Compare September 11, 2022 19:36
@oprypin
Add plugin events that persist across builds in mkdocs serve
a56ac6e 
"One-time events" `on_startup(command)`, `on_shutdown`.

Their presence also shows that a plugin *wants* to persist across builds. Otherwise they will be re-created, to not change any existing behavior.
@oprypin
on_startup: also pass a boolean dirty to detect --dirtyreload
e441347
@oprypin oprypin merged commit 8c3ea5f into master Sep 14, 2022
@oprypin oprypin deleted the onshut branch September 17, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: on_cleanup event type Allow plugins to detect --dirtyreload
1 participant
@oprypin