Fixed broken scripts from schema change on system_scope #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
=========================================
Coverage 25.21% 25.21%
Complexity 912 912
=========================================
Files 209 209
Lines 11689 11689
Branches 2116 2116
=========================================
Hits 2947 2947
Misses 8227 8227
Partials 515 515Continue to review full report at Codecov.
|
|
Thanks, we missed that on the 1.3 release somehow and this is the first complaint I've seen! |
|
Though FWIW, these scripts are really only meant to be used by temporary databases. Production systems should not be running these on startup. |
|
Agreed. It's just nice to have if someone wants to bootstrap for development or have a reference implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When system_scope changed, the scope scripts for all databases needed to change as well.