Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Oracle create script #1405

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

angelok1
Copy link
Contributor

The oracle create script doesn't properly cleanup after itself if re-run.

@codecov-io
Copy link

Codecov Report

Merging #1405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1405   +/-   ##
=========================================
  Coverage     25.21%   25.21%           
  Complexity      912      912           
=========================================
  Files           209      209           
  Lines         11689    11689           
  Branches       2116     2116           
=========================================
  Hits           2947     2947           
  Misses         8227     8227           
  Partials        515      515

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 802e40e...69afba5. Read the comment docs.

@jricher
Copy link
Member

jricher commented Jun 11, 2018

I'm not an oracle expert and have no means of testing this, so as with other Oracle DB stuff I'm going to have to trust that this is correct.

@jricher jricher merged commit 04f439e into mitreid-connect:master Jun 11, 2018
@angelok1 angelok1 deleted the db_script_fixes branch June 11, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants