Named Arguments #625
Merged
Named Arguments #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: jansul <jon@sul.ly>
Sija
reviewed
Aug 9, 2023
| .parameters | ||
| .index { |param| param.label == argument.name.try(&.value) } | ||
|
|
||
| raise CallNotFoundArgument, { |
There was a problem hiding this comment.
Suggested change
| raise CallNotFoundArgument, { | |
| raise ArgumentNameMismatch, { |
There was a problem hiding this comment.
I don't agree with change, it's not a mismatch (although it could be) but a not found parameter.
If we really need to change this, then It could be CallArgumentNameMismatch.
Comment on lines
-21
to
+31
| parameters.map(&.to_pretty.as(String)) | ||
| parameters.map do |param| | ||
| pretty = | ||
| param.to_pretty.as(String) | ||
|
|
||
| if param.label | ||
| "#{param.label}: #{pretty}" | ||
| else | ||
| pretty | ||
| end | ||
| end |
There was a problem hiding this comment.
I'd refactor this into Record#to_pretty(named_arguments: true).
[skip ci] Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
[skip ci] Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
|
As a side note: I'd use Calls with named arguments or Named arguments in calls wording rather than Labeled calls, which IMO is a bit abstract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to call functions with an alternative syntax using the names of the arguments.
The only rule as of now is that there can't be normal arguments and labelled arguments in a call.