Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Real-time Chat-bots (Slack) with Handler Memory #10286

Merged
merged 14 commits into from
Jan 20, 2025

Conversation

MinuraPunchihewa
Copy link
Contributor

@MinuraPunchihewa MinuraPunchihewa commented Dec 13, 2024

Description

This PR enables the use of real-time chat-bots with handler memory instead of always defaulting to DB memory.

Fixes https://linear.app/mindsdb/issue/BE-566/chatbot-handler-memory

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)

Verification Process

To ensure the changes are working as expected:

  • Test Location: Specify the URL or path for testing.
  • Verification Steps: Outline the steps or queries needed to validate the change. Include any data, configurations, or actions required to reproduce or see the new functionality.

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

image

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa
Copy link
Contributor Author

Hey @ea-rus, @ZoranPandovski,
This is the implementation of real-time (Slack) chat-bots with handler memory; I am leaving it as a draft PR because I am not certain if this is something we will merge right away since our customer is using the integration already?

@ea-rus I also made a few small changes to clean the logic for storing chat IDs in the internal DB as we discussed here.

Copy link
Contributor

@ea-rus ea-rus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ZoranPandovski ZoranPandovski marked this pull request as ready for review January 20, 2025 14:59
@ZoranPandovski ZoranPandovski merged commit e2db3e4 into main Jan 20, 2025
14 checks passed
@ZoranPandovski ZoranPandovski deleted the feature/slack_chatbot_with_handler_memory_2 branch January 20, 2025 14:59
@mindsdb mindsdb locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants